time: A colon is missing when formatting a time zone with seconds

[jstemmer]

What does 'go version' print?
go version devel +a4de97b5ea66 Fri Aug 08 16:20:20 2014 +0900 linux/amd64

What steps reproduce the problem?
Try to format a time zone with seconds using one of the colon layouts.
http://play.golang.org/p/CWRGALvwh9

What happened?
The time zone part is formatted as "+0019:32"

What should have happened instead?
The time zone part should be "+00:19:32"

Please provide any additional information below.

Here's a proposed CL to fix this:
https://golang.org/cl/126840043/

[cznic]

Comment 1:

From the docs[0]:
""""
Numeric time zone offsets format as follows:
-0700  ±hhmm
-07:00 ±hh:mm
Replacing the sign in the format with a Z triggers the ISO 8601 behavior of printing Z
instead of an offset for the UTC zone. Thus:
Z0700  Z or ±hhmm
Z07:00 Z or ±hh:mm
""""
The program uses "-07:00:00" for the zone format. That's is invalid as it's none of the
above supported formats.
  [0]: http://golang.org/pkg/time/#pkg-constants

[jstemmer]

Comment 2:

issue #4934 added support for parsing and formatting time zones with seconds, "-07:00:00"
is a valid zone format. If you remove the colons from the format layout in the
playground example I posted it will correctly print the time zone with seconds.

[ianlancetaylor]

Comment 3:

Labels changed: added repo-main, release-go1.4.

Status changed to Accepted.

[ianlancetaylor]

Comment 4:

https://golang.org/cl/126840043/

Status changed to Started.

[gopherbot]

Comment 5:

CL https://golang.org/cl/126840043 mentions this issue.

[robpike]

Comment 6:

This issue was closed by revision 298c623.

Status changed to Fixed.