Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: doesn't verify certificates #851

Closed
rsc opened this issue Jun 9, 2010 · 1 comment
Closed

crypto/tls: doesn't verify certificates #851

rsc opened this issue Jun 9, 2010 · 1 comment
Labels
FrozenDueToAge

Comments

@rsc
Copy link
Contributor

rsc commented Jun 9, 2010 

// TODO(rsc): Find certificates for OS X 10.6.
    if false && config.RootCAs != nil {
        root := config.RootCAs.FindParent(certs[len(certs)-1])
        if root == nil {

should drop the false && even if the TODO doesn't happen soon.
@rsc
Copy link
Contributor Author

rsc commented Jul 29, 2010

Comment 1:

This issue was closed by revision 4f64ecf.

Status changed to Fixed.

@rsc rsc added the fixed label Jul 29, 2010
@rsc rsc self-assigned this Jul 29, 2010
@mikioh mikioh changed the title crypto/tls doesn't verify certificates crypto/tls: doesn't verify certificates Jan 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
@fhs @rsc
http: add https client support
5f134f7 
Fixes golang#851.

R=rsc
CC=golang-dev
https://golang.org/cl/1729052
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsc @gopherbot