Skip to content

runtime: heapdump records incorrect info for data and bss #8530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rsc opened this issue Aug 14, 2014 · 2 comments
Closed

runtime: heapdump records incorrect info for data and bss #8530

rsc opened this issue Aug 14, 2014 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@rsc
Copy link
Contributor

rsc commented Aug 14, 2014 

dumpfields((BitVector){(edata - data)*8, (byte*)gcdata});
    dumpfields((BitVector){(ebss - bss)*8, (byte*)gcbss});

These lines look wrong. Dmitriy's change to the garbage collector made the gcdata and
gcbss 'programs', not bitmaps. But here they are being used as bitmaps.
@gopherbot
Copy link
Contributor

Comment 1:

CL https://golang.org/cl/124440043 mentions this issue.

@dvyukov
Copy link
Member

dvyukov commented Aug 18, 2014

Comment 2:

This issue was closed by revision 101c00a.

Status changed to Fixed.

@rsc rsc added fixed labels Aug 18, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@dvyukov @wheatman
runtime: fix dump of data/bss
8f4300e 
Fixes golang#8530.

LGTM=khr
R=golang-codereviews, khr
CC=golang-codereviews, rsc
https://golang.org/cl/124440043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@dvyukov @wheatman
runtime: fix dump of data/bss
afdf61c 
Fixes golang#8530.

LGTM=khr
R=golang-codereviews, khr
CC=golang-codereviews, rsc
https://golang.org/cl/124440043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@rsc @dvyukov @gopherbot