Skip to content

runtime: getgcmask is broken #8531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rsc opened this issue Aug 14, 2014 · 2 comments
Closed

runtime: getgcmask is broken #8531

rsc opened this issue Aug 14, 2014 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@rsc
Copy link
Contributor

rsc commented Aug 14, 2014 

getgcmask contains:

bits = (bv.data[off/PointersPerByte] >>
((off%PointersPerByte)*BitsPerPointer))&BitsMask;

bv.data is an array of uint32s but this is using offsets computed for an array of bytes.

The comment says
// Returns GC type info for object p for testing.

but it's hard to see how testing didn't find this.
@gopherbot
Copy link
Contributor

Comment 1:

CL https://golang.org/cl/124450043 mentions this issue.

@dvyukov
Copy link
Member

dvyukov commented Aug 15, 2014

Comment 2:

This issue was closed by revision c5e648d.

Status changed to Fixed.

@rsc rsc added fixed labels Aug 15, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@dvyukov @wheatman
runtime: fix getgcmask
b0279e7 
bv.data is an array of uint32s but the code was using
offsets computed for an array of bytes.
Add a test for stack GC info.
Fixes golang#8531.

LGTM=rsc
R=golang-codereviews
CC=golang-codereviews, khr, rsc
https://golang.org/cl/124450043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@dvyukov @wheatman
runtime: fix getgcmask
6e84d92 
bv.data is an array of uint32s but the code was using
offsets computed for an array of bytes.
Add a test for stack GC info.
Fixes golang#8531.

LGTM=rsc
R=golang-codereviews
CC=golang-codereviews, khr, rsc
https://golang.org/cl/124450043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@rsc @dvyukov @gopherbot