Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: TestParseInSydney fails on Linux after tzdata package update #8547

Closed
ALTree opened this issue Aug 18, 2014 · 7 comments

Comments

Projects
None yet
6 participants
@ALTree
Copy link
Member

commented Aug 18, 2014

go version: go1.3 linux/amd64


Package tzdata was recently bumped on Debian Testing from tzdata-2014e to tzdata-2014f.
The fix to this bug:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602162

changed some of the Australian abbreviations from EST to AEST and AEDT. 

a test in TestParseInSydney expect EST, and thus it fails.



What steps reproduce the problem?

1. run ./all.bash


What happened?

--- FAIL: TestParseInSydney (0.00 seconds)
    format_test.go:201: ParseInLocation(Feb 01 2013 EST, Sydney) = 2013-02-01 00:00:00 +0000 EST, want 2013-02-01 00:00:00 +1100 AEDT


What should have happened instead?

PASS
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2014

Comment 1:

Labels changed: added repo-main, release-go1.4.

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2014

Comment 2:

Proposed fix
https://golang.org/cl/130920043
as suggested(?) in the mailing list, I changed the test to ensure that 
ParseInLocation doesn't get confused with different timezones having the 
same abbreviation
@gopherbot

This comment has been minimized.

Copy link

commented Aug 19, 2014

Comment 3:

CL https://golang.org/cl/130920043 mentions this issue.
@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 21, 2014

Comment 4:

This issue was closed by revision 5e70140.

Status changed to Fixed.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

Comment 5:

Issue #8814 has been merged into this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Sep 29, 2014

Comment 6:

CL https://golang.org/cl/153720043 mentions this issue.
@adg

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2014

Comment 7:

This issue was closed by revision e11f3e56a8bf.

@ALTree ALTree added fixed labels Sep 29, 2014

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015

@rsc rsc removed the release-go1.4 label Apr 14, 2015

adg added a commit that referenced this issue May 11, 2015

[release-branch.go1.3] time: removed from tests now obsolete assumpti…
…on about Australian tz abbreviations

««« CL 130920043 / 7dba9475ee72
time: removed from tests now obsolete assumption about Australian tz abbreviations

Australian timezones abbreviation for standard and daylight saving time were recently
changed from EST for both to AEST and AEDT in the icann tz database (see changelog
on www.iana.org/time-zones).

A test in the time package was written to check that the ParseInLocation function
understand that Feb EST and Aug EST are different time zones, even though they are
both called EST. This is no longer the case, and the Date function now returns
AEST or AEDT for australian tz on every Linux system with an up to date tz database
(and this makes the test fail).

Since I wasn't able to find another country that 1) uses daylight saving and 2) has
the same abbreviation for both on tzdata, I changed the test to make sure that
ParseInLocation does not get confused when it parses, in different locations, two
dates with the same abbreviation (this was suggested in the mailing list).

Fixes #8547.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/130920043

»»»

LGTM=dsymonds
R=rsc, dsymonds
CC=golang-codereviews
https://golang.org/cl/153720043

@golang golang locked and limited conversation to collaborators Jun 25, 2016

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018

time: removed from tests now obsolete assumption about Australian tz …
…abbreviations

Australian timezones abbreviation for standard and daylight saving time were recently
changed from EST for both to AEST and AEDT in the icann tz database (see changelog
on www.iana.org/time-zones).

A test in the time package was written to check that the ParseInLocation function
understand that Feb EST and Aug EST are different time zones, even though they are
both called EST. This is no longer the case, and the Date function now returns
AEST or AEDT for australian tz on every Linux system with an up to date tz database
(and this makes the test fail).

Since I wasn't able to find another country that 1) uses daylight saving and 2) has
the same abbreviation for both on tzdata, I changed the test to make sure that
ParseInLocation does not get confused when it parses, in different locations, two
dates with the same abbreviation (this was suggested in the mailing list).

Fixes golang#8547.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/130920043

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018

time: removed from tests now obsolete assumption about Australian tz …
…abbreviations

Australian timezones abbreviation for standard and daylight saving time were recently
changed from EST for both to AEST and AEDT in the icann tz database (see changelog
on www.iana.org/time-zones).

A test in the time package was written to check that the ParseInLocation function
understand that Feb EST and Aug EST are different time zones, even though they are
both called EST. This is no longer the case, and the Date function now returns
AEST or AEDT for australian tz on every Linux system with an up to date tz database
(and this makes the test fail).

Since I wasn't able to find another country that 1) uses daylight saving and 2) has
the same abbreviation for both on tzdata, I changed the test to make sure that
ParseInLocation does not get confused when it parses, in different locations, two
dates with the same abbreviation (this was suggested in the mailing list).

Fixes golang#8547.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/130920043

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.