Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: error when viewing /pkg/ over HTTP #8572

Closed
bradfitz opened this issue Aug 22, 2014 · 6 comments

Comments

Projects
None yet
4 participants
@bradfitz
Copy link
Member

commented Aug 22, 2014

Using current tip godoc and Go tree, I can't view /pkg/

See screenshot.

I have no file named conv.go. I'm not sure what it's angry about.

Attachments:

  1. conv-godoc.png (133117 bytes)
@adg

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2014

Comment 1:

What about your GOPATH?
IIRC godoc maps GOPATH to /src/pkg
try 
  GOPATH= godoc -http=localhost:6060
and see if it still happens

Status changed to WaitingForReply.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2014

Comment 2:

My $GOPATH is $HOME.
I can no longer reproduce, with or without GOPATH set. 
But more generaly: a single corrupt go file in my GOPATH shouldn't stop rendering all of
godoc. At most, it should show an error for just that package, and it should just drop
the package from the package list (or render it with an package summary that is just the
parse error message).

Status changed to Accepted.

@adg

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2014

Comment 3:

So you can't reproduce it? Any idea how I could reproduce it myself?
Otherwise this report isn't very actionable.
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2014

Comment 4:

I can reproduce it if I put an empty or bogus Go file at $GOROOT/src/pkg/bogus.go.
But as shown in the screenshot above, I didn't have that file there before. So I'm
confused how I temporarily entered that state.
@rsc

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2014

Comment 5:

Doesn't sound like anyone is going to fix this for 1.4.

Labels changed: added release-go1.5, removed release-go1.4.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2014

Comment 6:

FWIW, I found the problem: I did have an incomplete file. But I don't think that should
stop godoc's package listing.
We can fix later.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014

@bradfitz bradfitz removed the release-go1.5 label Dec 16, 2014

@rsc rsc removed accepted labels Apr 14, 2015

@rsc rsc changed the title cmd/godoc: error when viewing /pkg/ over HTTP x/tools/cmd/godoc: error when viewing /pkg/ over HTTP Apr 14, 2015

@rsc rsc modified the milestones: Unplanned, Go1.5 Apr 14, 2015

@rsc rsc removed the repo-tools label Apr 14, 2015

@adg adg closed this Feb 26, 2016

@golang golang locked and limited conversation to collaborators Feb 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.