New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/tls: Conn missing CloseRead / CloseWrite #8579
Comments
Labels changed: added repo-main. Owner changed to @agl. Status changed to Accepted. |
> They should probably be defined on net.Conn unfortunately we can't break the go1 contract; http://golang.org/doc/go1compat/. |
I don't think this will happen. The input to TLS is a net.Conn, and we can't add them there. crypto/tls would have to sniff for them, and what if the underlying net.Conn doesn't support them? |
@rsc It may be helpful here to be able to get the underlying net.Conn? |
CL https://golang.org/cl/25159 mentions this issue. |
The CloseWrite method sends a close_notify alert record to the other side of the connection. This record indicates that the sender has finished sending on the connection. Unlike the Close method, the sender may still read from the connection until it recieves a close_notify record (or the underlying connection is closed). This is analogous to a TCP half-close. Updates #8579 Change-Id: I9c6bc193efcb25cc187f7735ee07170afa7fdde3 Reviewed-on: https://go-review.googlesource.com/25159 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
CL https://golang.org/cl/31318 mentions this issue. |
Reopening, CL 25159 has been reverted. |
The CloseWrite method sends a close_notify alert record to the other side of the connection. This record indicates that the sender has finished sending on the connection. Unlike the Close method, the sender may still read from the connection until it recieves a close_notify record (or the underlying connection is closed). This is analogous to a TCP half-close. This is a rework of CL 25159 with fixes for the unstable test. Updates #8579 Change-Id: I47608d2f82a88baff07a90fd64c280ed16a60d5e Reviewed-on: https://go-review.googlesource.com/31318 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Looks fixed to me (CloseRead doesn't make sense per discussion on CL 25159).
|
Yep +1. Really happy to have |
by justin@fathomdb.com:
The text was updated successfully, but these errors were encountered: