testing: go -cover -race finds race in coverage code @ tip
#8630
Labels
Milestone
Comments
Right, the coverage code has a race (or a false positive). Yes, I can confirm that turning off coverage (and nothing else) causes the races to go away: https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/34241151 |
CL https://golang.org/cl/141800043 mentions this issue. |
|
This issue was closed by revision d33ee0c. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
For -mode=atomic, we need to read the counters using an atomic load to avoid a race. Not worth worrying about when -mode=atomic is set during generation of the profile, so we use atomic loads always. Fixes golang#8630. LGTM=rsc R=dvyukov, rsc CC=golang-codereviews https://golang.org/cl/141800043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
For -mode=atomic, we need to read the counters using an atomic load to avoid a race. Not worth worrying about when -mode=atomic is set during generation of the profile, so we use atomic loads always. Fixes golang#8630. LGTM=rsc R=dvyukov, rsc CC=golang-codereviews https://golang.org/cl/141800043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
For -mode=atomic, we need to read the counters using an atomic load to avoid a race. Not worth worrying about when -mode=atomic is set during generation of the profile, so we use atomic loads always. Fixes golang#8630. LGTM=rsc R=dvyukov, rsc CC=golang-codereviews https://golang.org/cl/141800043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
$ go version go version devel +a1d74ad863fb Tue Sep 02 12:23:49 2014 -0700 linux/amd64 One sample race: ================== WARNING: DATA RACE Read by main goroutine: testing.coverReport() /home/travis/.gvm/gos/tip/src/pkg/testing/cover.go:89 +0x4f8 testing.after() /home/travis/.gvm/gos/tip/src/pkg/testing/testing.go:596 +0x89d testing.Main() /home/travis/.gvm/gos/tip/src/pkg/testing/testing.go:450 +0x1e1 main.main() github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config/_test/_testmain.go:117 +0x17a Previous write by goroutine 11: sync/atomic.AddInt32() /home/travis/.gvm/gos/tip/src/pkg/runtime/race_amd64.s:255 +0xc github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config.handleServicesWatch() github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config/_test/_obj_test/api.go:93 +0x261 github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config.(*SourceAPI).runServices() github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config/_test/_obj_test/api.go:71 +0x44b github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config.func·007() /home/travis/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config/api_test.go:39 +0x5e Goroutine 11 (running) created at: github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config.TestServices() /home/travis/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/proxy/config/api_test.go:40 +0x377 testing.tRunner() /home/travis/.gvm/gos/tip/src/pkg/testing/testing.go:427 +0x112 ==================The text was updated successfully, but these errors were encountered: