Skip to content

runtime: make GC runtime stats test run on GCE #8634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bradfitz opened this issue Sep 3, 2014 · 2 comments
Open

runtime: make GC runtime stats test run on GCE #8634

bradfitz opened this issue Sep 3, 2014 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Sep 3, 2014

In https://code.google.com/p/go/source/detail?r=ec6629ef3dae19 I removed part of a test
that Dmitry liked because it doesn't run on GCE (which only has ~1ms timers apparently).

This bug is about restoring the test somehow. We could make it a -short test (so it's
skipped on builders, but runs on our machiens). Or try the test first and if we get a
0ns pause, then generate a lot of garbage and try for a >= 1 ms GC pause, which is
measurable on Windows (physical hardware) and GCE (any OS).
@griesemer
Copy link
Contributor

Comment 1:

Labels changed: added repo-main.

@rsc
Copy link
Contributor

rsc commented Apr 10, 2015

There are 256 pause times in ms.PauseNs. The code could look at them to see if there is any sub-ms granularity, or anything < 1ms, before rejecting 0.

@dvyukov

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed accepted labels Apr 14, 2015
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants