Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: flaky TestReloadResolvConfFail #8652

Closed
mikioh opened this issue Sep 4, 2014 · 4 comments

Comments

Projects
None yet
6 participants
@mikioh
Copy link
Contributor

commented Sep 4, 2014

it sometimes fails on darwin:

-- FAIL: TestReloadResolvConfFail (1.21s)
    dnsclient_unix_test.go:182: goLookupIP(missing; good) failed: stat /var/folders/7d/d3y9vsls2yd880k121jmzcyr0000gn/T/resolvConfTest018927742/resolv.conf: no such file or directory
FAIL

@mikioh mikioh added new labels Sep 4, 2014

@bradfitz bradfitz removed the new label Dec 18, 2014

@zachgersh

This comment has been minimized.

Copy link

commented Feb 2, 2015

I could totally grab this as well.

@4ad

This comment has been minimized.

Copy link
Member

commented Mar 17, 2015

Happens on Solaris reliably.

@4ad

This comment has been minimized.

Copy link
Member

commented Mar 17, 2015

This fixes it, although I don't quite know why:

diff --git a/src/net/dnsclient_unix_test.go b/src/net/dnsclient_unix_test.go
index 40b78bd..bfae88c 100644
--- a/src/net/dnsclient_unix_test.go
+++ b/src/net/dnsclient_unix_test.go
@@ -143,6 +143,7 @@ func (r *resolvConfTest) SetConf(s string) {
        cfg.ch <- struct{}{} // fill buffer
        cfg.ch <- struct{}{} // wait for reload to begin
        cfg.ch <- struct{}{} // wait for reload to complete
+       cfg.ch <- struct{}{}
    }
 }

@rsc rsc added this to the Go1.5Maybe milestone Apr 10, 2015

@rsc rsc removed the repo-main label Apr 14, 2015

@mikioh mikioh added the Testing label May 2, 2015

@gopherbot

This comment has been minimized.

Copy link

commented May 14, 2015

CL https://golang.org/cl/9991 mentions this issue.

@bradfitz bradfitz closed this in ef7e108 May 15, 2015

@mikioh mikioh modified the milestones: Go1.5, Go1.5Maybe May 15, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.