Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: flaky Windows TestAcceptIgnoreSomeErrors #8662

Closed
bradfitz opened this issue Sep 5, 2014 · 7 comments

Comments

Projects
None yet
6 participants
@bradfitz
Copy link
Member

commented Sep 5, 2014

The new GCE builders for windows-amd64 and windows-386 are getting this error a lot:

--- FAIL: TestAcceptIgnoreSomeErrors (0.55s)
    net_windows_test.go:126: recv failed: WSARecv tcp 127.0.0.1:51298: An existing connection was forcibly closed by the remote host.
FAIL
FAIL    net 3.711s


The test looks very sleep & timing dependent.

Can you make it more robust or disable it in short mode?
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2014

Comment 1:

One thing to keep in mind is that GCE monotonic time passes is very slow ticks, like 1
millisecond, instead of 50 nanoseconds of Linux on physical hardware. So if you have
something that's very timing-sensitive, GCE will just make it worse.  Or maybe Windows
in general is also just bad at that IIRC.
@alexbrainman

This comment has been minimized.

Copy link
Member

commented Sep 5, 2014

Comment 2:

Windows ticks are around 15-10ms (milliseconds), 1ms in best scenario. I doubt GCE does
better then 15-10ms.
Alex
@gopherbot

This comment has been minimized.

Copy link

commented Sep 5, 2014

Comment 3:

CL https://golang.org/cl/138120043 mentions this issue.
@alexbrainman

This comment has been minimized.

Copy link
Member

commented Sep 5, 2014

Comment 4:

This issue was updated by revision 0f9b6af.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/138120043
Committer: Brad Fitzpatrick 
@rsc

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2014

Comment 5:

Labels changed: added release-none, removed release-go1.4.

@adg

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2014

Comment 6:

This issue was updated by revision b2974dc26ab7.
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/138120043
Committer: Brad Fitzpatrick <bradfitz@golang.org>
»»»
LGTM=dsymonds
R=dsymonds
CC=golang-codereviews
https://golang.org/cl/149200043

@rsc rsc removed the os-windows label Apr 10, 2015

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc added OS-Windows and removed release-none labels Apr 10, 2015

@mikioh mikioh added the Testing label May 2, 2015

@gopherbot

This comment has been minimized.

Copy link

commented May 10, 2015

CL https://golang.org/cl/9911 mentions this issue.

adg added a commit that referenced this issue May 11, 2015

[release-branch.go1.3] net: temporarily skip TestAcceptIgnoreSomeErrors
««« CL 138120043 / 9a36c3ea7015
net: temporarily skip TestAcceptIgnoreSomeErrors

Update #8662

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/138120043

»»»

LGTM=dsymonds
R=dsymonds
CC=golang-codereviews
https://golang.org/cl/149200043

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.