Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: SetKeepAlivePeriod doesn't work well on OpenBSD #8679

Closed
mikioh opened this issue Sep 8, 2014 · 4 comments

Comments

Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
2 participants
@mikioh @gopherbot
@mikioh
Copy link
Contributor

commented Sep 8, 2014 

Because OpenBSD doesn't support such options. The changeset 17287:b4365c5e2d05 is wrong.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 8, 2014

Comment 1:

CL https://golang.org/cl/141730043 mentions this issue.
@mikioh

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 8, 2014

Comment 2:

This issue was closed by revision 1fadd9e.

Status changed to Fixed.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2014

Comment 3:

CL https://golang.org/cl/136480043 mentions this issue.
@mikioh

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 11, 2014

Comment 4:

This issue was updated by revision f956740.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/136480043

@mikioh mikioh added the fixed label Sep 11, 2014

@golang golang locked and limited conversation to collaborators Jun 25, 2016

@gopherbot gopherbot added the FrozenDueToAge label Jun 25, 2016

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018

Mikio Hara @wheatman
net: don't set wrong option for controlling tcp keepalive on openbsd 
Fixes golang#8679.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/141730043
bebe530

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018

Mikio Hara @wheatman
net: don't set wrong option for controlling tcp keepalive on openbsd 
Fixes golang#8679.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/141730043
8bac5a3

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018

Mikio Hara @wheatman
net: don't set wrong option for controlling tcp keepalive on openbsd 
Fixes golang#8679.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/141730043
b9782ba

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.