Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/signal: flaky TestNohup timeout too short? #8682

Closed
bradfitz opened this issue Sep 8, 2014 · 2 comments
Closed

os/signal: flaky TestNohup timeout too short? #8682

bradfitz opened this issue Sep 8, 2014 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Sep 8, 2014 

From http://build.golang.org/log/0c83487a5242e57afdcb835556b4de3248d90147

ok      os  1.171s
ok      os/exec 0.740s
--- FAIL: TestNohup (0.10s)
    signal_test.go:186: ran test with -send_uncaught_sighup=1 and it succeeded: expected failure.
        Output:
        PASS
FAIL
FAIL    os/signal   0.355s
ok      os/user 0.015s
ok      path    0.067s
ok      path/filepath   0.103s

Russ thinks the 0.10 timeout might be too short.
@gopherbot
Copy link
Contributor

Comment 1:

CL https://golang.org/cl/143160043 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Sep 16, 2014

Comment 2:

This issue was closed by revision c1e3320.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@rsc @wheatman
os/signal: increase timeout from 10ms to 100ms
e2e598e 
Might make test less flaky.
Fixes golang#8682.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/143160043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@rsc @wheatman
os/signal: increase timeout from 10ms to 100ms
f993481 
Might make test less flaky.
Fixes golang#8682.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/143160043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@rsc @wheatman
os/signal: increase timeout from 10ms to 100ms
1c4611b 
Might make test less flaky.
Fixes golang#8682.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/143160043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot