Skip to content

image: Rectangle.{Overlaps,Intersect} doesn't check for 1 pixel overlaps #8695

@OneOfOne

Description

@OneOfOne
Overlaps and Intersect should use >= / <= for their checks.

func (r Rectangle) Overlaps(s Rectangle) bool {
    return r.Min.X <= s.Max.X && s.Min.X <= r.Max.X &&
        r.Min.Y <= s.Max.Y && s.Min.Y <= r.Max.Y
}

instead of 

func (r Rectangle) Overlaps(s Rectangle) bool {
    return r.Min.X < s.Max.X && s.Min.X < r.Max.X &&
        r.Min.Y < s.Max.Y && s.Min.Y < r.Max.Y
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions