Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: minor typo in documentation #8797

Closed
t-yuki opened this issue Sep 24, 2014 · 3 comments
Closed

testing: minor typo in documentation #8797

t-yuki opened this issue Sep 24, 2014 · 3 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge

Comments

@t-yuki
Copy link

t-yuki commented Sep 24, 2014 

https://code.google.com/p/go/source/browse/src/testing/testing.go?r=804cc55d6b47e49e4bf46baa4ca9ec44b9684bed#47
It says `The benchmark package will vary b.N`... but there are no `benchmark` package
currently.
It should be `The package will vary b.N` with taking account of the description in
Example section. In this context, `the package` indicates testing package.
@ianlancetaylor
Copy link
Member

Comment 1:

Labels changed: added repo-main, release-none, documentation.

@gopherbot
Copy link
Contributor

Comment 2:

CL https://golang.org/cl/146680043 mentions this issue.

@griesemer
Copy link
Contributor

Comment 3:

This issue was closed by revision 5edff32.

Status changed to Fixed.

@t-yuki t-yuki added fixed Documentation Issues describing a change to documentation. labels Oct 1, 2014
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@griesemer @wheatman
testing: clearer comment
c4a5e6e 
Fixes golang#8797.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/146680043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@griesemer @wheatman
testing: clearer comment
c25725b 
Fixes golang#8797.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/146680043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@griesemer @wheatman
testing: clearer comment
590cc3f 
Fixes golang#8797.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/146680043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@griesemer @wheatman
testing: clearer comment
5f8c21c 
Fixes golang#8797.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/146680043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ianlancetaylor @t-yuki @griesemer @gopherbot