Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: add new Go version #8798

Closed
rsc opened this issue Sep 24, 2014 · 6 comments
Closed

cmd/pprof: add new Go version #8798

rsc opened this issue Sep 24, 2014 · 6 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Sep 24, 2014

A new Go version of pprof has replaced the original Perl script within Google (even for
non-Go programmers).

We should replace the public Go repo's copy of the Perl script with the new Go version.
This will make Perl not required to use pprof, which is especially useful on Windows.
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 29, 2014

Comment 1:

CL https://golang.org/cl/153750043 mentions this issue.
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 30, 2014

Comment 2:

CL https://golang.org/cl/153750044 mentions this issue.
@rsc
Copy link
Contributor Author

@rsc rsc commented Sep 30, 2014

Comment 3:

This issue was updated by revision c75f81f.

LGTM=bradfitz
R=crawshaw, bradfitz
CC=golang-codereviews
https://golang.org/cl/153750044
@rsc
Copy link
Contributor Author

@rsc rsc commented Sep 30, 2014

Comment 4:

This issue was updated by revision 8b5221a.

This is a new implementation of pprof,
written in Go instead of in Perl.
It was written primarily by Raul Silvera and
is in use for profiling programs of all languages
inside Google.
The internal structure is a bit package-heavy,
but it matches the copy used inside Google, and
since it is in an internal directory, we can make
changes to it later if we need to.
The only "new" file here is src/cmd/pprof/pprof.go,
which stitches together the Google pprof and the
Go command libraries for object file access.
I am explicitly NOT interested in style or review
comments on the rest of the files
(that is, src/cmd/pprof/internal/...).
Those are intended to stay as close to the Google
copies as possible, like we did with the pprof Perl script.
Still to do:
- Basic tests.
- Real command documentation.
- Hook up disassemblers.
LGTM=r
R=r, bradfitz, alex.brainman, dave
CC=golang-codereviews
https://golang.org/cl/153750043
@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 1, 2014

Comment 5:

Labels changed: added repo-main.

@rsc
Copy link
Contributor Author

@rsc rsc commented Nov 19, 2014

Comment 6:

I've done as much as I'm going to do this round.

Status changed to Fixed.

@rsc rsc added fixed labels Nov 19, 2014
@rsc rsc self-assigned this Nov 19, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.