Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: Failing test: TestParseInSydney in Go 1.3.2 #8814

Closed
tamasd opened this issue Sep 26, 2014 · 4 comments

Comments

Projects
None yet
6 participants
@tamasd
Copy link

commented Sep 26, 2014

What does 'go version' print?

go version go1.3.2 darwin/amd64

What steps reproduce the problem?

1. hg pull && hg update
2. cd src
3. ./all.bash

What happened?

--- FAIL: TestParseInSydney (0.00 seconds)
    format_test.go:201: ParseInLocation(Feb 01 2013 EST, Sydney) = 2013-02-01 00:00:00 +0000 EST, want 2013-02-01 00:00:00 +1100 AEDT

Please provide any additional information below.

I have Mac OS X Mavericks 10.9.5. I removed the original installation and tried to build
on a fresh clone but I got the same result.
@gopherbot

This comment has been minimized.

Copy link

commented Sep 26, 2014

Comment 1 by eduncan911:

Same failed test here.
Version:
go version go1.3.2 linux/amd64
Steps to reproduce:
cd /usr/local/go
sudo hg pull
sudo hg update release # per Andrew's instructions
cd src
sudo ./all.bash
What happened:
--- FAIL: TestParseInSydney (0.00 seconds)
    format_test.go:201: ParseInLocation(Feb 01 2013 EST, Sydney) = 2013-02-01 00:00:00 +0000 EST, want 2013-02-01 00:00:00 +1100 AEDT
FAIL
FAIL    time    2.416s
Additional info:
OS: Debian Testing w/latest as of 9/25.  
Running in a VirtualBox VM on OSX, configured for "Hardware clock in UTC time" Which
states, "If checked, VirtualBox will report the system time in UTC format to the guest
instead of local (host) time. This affects how the virtual real-time clock (RTC)
operates and may be useful for Unix-like guest operating systems, which typically expect
the hardware clock to be set to UTC."
As mentioned by the reporter, I also removed the installation and pulled a fresh copy -
no modifications.  
But, I continue to have the build error.
Andrew mentioned in the google thread that its a timezone issue: 
https://groups.google.com/d/msg/golang-nuts/eeOHNw_shwU/hpoUb4OKUdEJ
As I mentioned above, I am passing UTC bios clock to my VM, but the Debian install is
set to EDT:
spdev01:/usr/local$ date
Fri Sep 26 08:21:44 EDT 2014
Thanks!
@bradfitz

This comment has been minimized.

Copy link
Member

commented Sep 26, 2014

Comment 2:

This was fixed at tip.
Maybe the test should be cherry-picked into the next 1.3 point release.

Labels changed: added release-go1.3.3.

@cznic

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

Comment 3:

Can you please link to where it was fixed? I have a possibly related bug and I cannot
find the fix at tip. TIA
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

Comment 4:

This is issue #8547.  The fix is https://golang.org/cl/130920043.

Status changed to Duplicate.

Merged into issue #8547.

@rsc rsc added this to the Go1.3.3 milestone Apr 14, 2015

@rsc rsc removed the release-go1.3.3 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.