Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: typo in CreateCertificateRequest docs #8936

Closed
gopherbot opened this issue Oct 15, 2014 · 2 comments
Closed

crypto/x509: typo in CreateCertificateRequest docs #8936

gopherbot opened this issue Oct 15, 2014 · 2 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 15, 2014

by carl@stripe.com:

The docs at http://golang.org/pkg/crypto/x509/#CreateCertificateRequest read:

"""
CreateCertificateRequest creates a new certificate based on a template. The following
members of template are used: Subject, Attributes, SignatureAlgorithm, Extension,
DNSNames, EmailAddresses, and IPAddresses. The private key is the private key of the
signer.
"""

The field on CertificateRequest is named "Extensions," not
"Extension"
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 15, 2014

Comment 1:

CL https://golang.org/cl/152590043 mentions this issue.
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 15, 2014

Comment 2:

This issue was closed by revision a681749.

Status changed to Fixed.

@gopherbot gopherbot added the fixed label Oct 15, 2014
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
Fixes golang#8936.

LGTM=bradfitz
R=agl, bradfitz
CC=golang-codereviews
https://golang.org/cl/152590043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
Fixes golang#8936.

LGTM=bradfitz
R=agl, bradfitz
CC=golang-codereviews
https://golang.org/cl/152590043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
Fixes golang#8936.

LGTM=bradfitz
R=agl, bradfitz
CC=golang-codereviews
https://golang.org/cl/152590043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
Fixes golang#8936.

LGTM=bradfitz
R=agl, bradfitz
CC=golang-codereviews
https://golang.org/cl/152590043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.