Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: Document that prepared statements must be Close()' #8952

Closed
augustoroman opened this issue Oct 17, 2014 · 3 comments
Closed

database/sql: Document that prepared statements must be Close()' #8952

augustoroman opened this issue Oct 17, 2014 · 3 comments

Comments

@augustoroman
Copy link
Contributor

@augustoroman augustoroman commented Oct 17, 2014

Before filing a bug, please check whether it has been fixed since the
latest release. Search the issue tracker and check that you're running the
latest version of Go:

Run "go version" and compare against
http://golang.org/doc/devel/release.html  If a newer version of Go exists,
install it and retry what you did to reproduce the problem.

Thanks.

What does 'go version' print?

What steps reproduce the problem?
If possible, include a link to a program on play.golang.org.

1.
2.
3.

What happened?

What should have happened instead?

Please provide any additional information below.
@augustoroman
Copy link
Contributor Author

@augustoroman augustoroman commented Oct 17, 2014

Comment 1:

Sorry, not sure what happened.  Here's the text that should be part of the bug:
go version 1.3.3
DB.Prepare (http://godoc.org/database/sql#DB.Prepare) and Tx.Stmt
(http://godoc.org/database/sql#Tx.Stmt) both return *Stmt that should be closed after
user, but this is not documented.
The only reference I could find was a brief mention in
https://code.google.com/p/go-wiki/wiki/SQLInterface.  None of the examples in either the
package docs or the wiki indicate that it should be closed.
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 17, 2014

Comment 2:

Labels changed: added repo-main, release-go1.5, documentation.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@rsc rsc removed the repo-main label Apr 14, 2015
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 15, 2015

CL https://golang.org/cl/12204 mentions this issue.

@rsc rsc closed this in 3c9f60c Jul 15, 2015
@golang golang locked and limited conversation to collaborators Jul 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.