Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Range request edge case #8988

Closed
gopherbot opened this issue Oct 23, 2014 · 6 comments

Comments

Projects
None yet
5 participants
@gopherbot
Copy link

commented Oct 23, 2014

by jed@fastly.com:

There's currently a bug with ServeContent and FileServer when handling Range requests.

Given a file of size N, a request for "Range: bytes=N-*" should return a 416. 
However, currently, it returns 206, a body of 0 bytes, and the illegal Content-Range of
"bytes N-(N-1)/N".
@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 23, 2014

Comment 1:

CL https://golang.org/cl/163820043 mentions this issue.
@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 23, 2014

Comment 2 by jed@fastly.com:

A fix for this issue is pending review: https://golang.org/cl/163820043
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2014

Comment 3:

Labels changed: added repo-main, release-go1.5.

@gopherbot gopherbot added new labels Oct 23, 2014

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014

@jeddenlea

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2014

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2014

Can you please consult for RFC 7233 instead of RFC 2616? I'm not sure how much impact will we have on http://tools.ietf.org/html/rfc7233#appendix-B.

@jeddenlea

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2014

So far as I can reason, the updated RFC doesn't change what should be done in the case this CL addresses. But I will update the language quoted in the change description.

@bradfitz bradfitz closed this in 474ce69 Dec 20, 2014

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.