Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/sha512: Arm Optimizations not implemented #9005

Open
gopherbot opened this issue Oct 27, 2014 · 6 comments
Open

crypto/sha512: Arm Optimizations not implemented #9005

gopherbot opened this issue Oct 27, 2014 · 6 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 27, 2014

by jeromyj:

sha family hash functions on ARM architectures are quite slow, there is an
implementation of sha512 (and sha1) in libgcrypt that has assembly optimized code for
ARM Neon. It would be really nice to have something similar implemented into the Go
standard library.
@davecheney
Copy link
Contributor

@davecheney davecheney commented Oct 27, 2014

Comment 1:

It would be great to have an assembly implementation of those crypto functions for arm.
There are two issues.
1. not all supported platforms support neon, so that means a non neon version would have
to be included and detected at runtime.
2. i am not a lawyer, and don't pretend to play one on tv, but the licence for libgcrypt
does not appear to be compatible with the Go licence.

Labels changed: added release-none, repo-main, arch-arm.

Status changed to Accepted.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 27, 2014

Comment 2 by jeromyj:

Couldnt the difference between neon code and code without be checked at compile time?
using a "*_neon.s" type file exension? Ive not looked too far into how the platform
specifiers work, so maybe thats not possible.

@minux
Copy link
Member

@minux minux commented Oct 27, 2014

Comment 3:

subarch build tag has been proposed before, but rejected (?).
even if we can select code based on subarch, you might still want to two copies of the
code
to run systems without NEON.

@rsc rsc removed the arch-arm label Apr 10, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@QiangHeisenberg
Copy link
Contributor

@QiangHeisenberg QiangHeisenberg commented Jun 20, 2020

cryto/sha512: Will the assembly submitted to arm64 now be accepted?

@andig
Copy link
Contributor

@andig andig commented Oct 14, 2021

@QiangHeisenberg I assume it will. There already are special cases in math/big for arm64 and sha256 has an arm64 implementation, too.

@andig
Copy link
Contributor

@andig andig commented Oct 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants