Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: TestDrivers not re-entrant #9024

Closed
gpaul opened this issue Oct 30, 2014 · 3 comments
Closed

database/sql: TestDrivers not re-entrant #9024

gpaul opened this issue Oct 30, 2014 · 3 comments
Milestone

Comments

@gpaul
Copy link
Contributor

@gpaul gpaul commented Oct 30, 2014

What does 'go version' print?
go version go1.4beta1 linux/amd64

What steps reproduce the problem?
go test database/sql -test.run=TestDrivers -test.cpu=4,4,4

What happened?
=== RUN TestDrivers-4
--- FAIL: TestDrivers-4 (0.00s)
panic: sql: Register called twice for driver invalid [recovered]
    panic: sql: Register called twice for driver invalid

goroutine 358 [running]:
testing.func·006()
    /home/gustav/go.tip/src/testing/testing.go:441 +0x181
database/sql.Register(0x5b9b10, 0x7, 0x7f008c2910d8, 0xc2081a7640)
    /home/gustav/go.tip/src/database/sql/sql.go:35 +0x135
database/sql.TestDrivers(0xc2081ca360)
    /home/gustav/go.tip/src/database/sql/fakedb_test.go:144 +0x96
testing.tRunner(0xc2081ca360, 0x695040)
    /home/gustav/go.tip/src/testing/testing.go:447 +0xbf
created by testing.RunTests
    /home/gustav/go.tip/src/testing/testing.go:555 +0xa8b

goroutine 1 [chan receive]:
testing.RunTests(0x609a88, 0x694fe0, 0x2c, 0x2c, 0x69a401)
    /home/gustav/go.tip/src/testing/testing.go:556 +0xad6
testing.(*M).Run(0xc2080560f0, 0x6a0e60)
    /home/gustav/go.tip/src/testing/testing.go:485 +0x6c
main.main()
    database/sql/_test/_testmain.go:156 +0x1d5
exit status 2
FAIL    database/sql    0.464s

What should have happened instead?
=== RUN TestDrivers-2
--- PASS: TestDrivers-2 (0.00s)
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 30, 2014

Comment 1:

Labels changed: added repo-main, release-go1.5.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 31, 2014

Comment 2:

CL https://golang.org/cl/169860043 mentions this issue.
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 31, 2014

Comment 3:

This issue was closed by revision 9dc1cce.

Status changed to Fixed.

@gpaul gpaul added fixed labels Oct 31, 2014
@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@bradfitz bradfitz removed the release-go1.5 label Dec 16, 2014
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
Using -test.cpu=1,1 made it crash before.

Fixes golang#9024

LGTM=iant
R=adg, iant
CC=golang-codereviews
https://golang.org/cl/169860043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
Using -test.cpu=1,1 made it crash before.

Fixes golang#9024

LGTM=iant
R=adg, iant
CC=golang-codereviews
https://golang.org/cl/169860043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
Using -test.cpu=1,1 made it crash before.

Fixes golang#9024

LGTM=iant
R=adg, iant
CC=golang-codereviews
https://golang.org/cl/169860043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018
Using -test.cpu=1,1 made it crash before.

Fixes golang#9024

LGTM=iant
R=adg, iant
CC=golang-codereviews
https://golang.org/cl/169860043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
Using -test.cpu=1,1 made it crash before.

Fixes golang#9024

LGTM=iant
R=adg, iant
CC=golang-codereviews
https://golang.org/cl/169860043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.