Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/parser: TestErrors not re-entrant #9025

gpaul opened this issue Oct 30, 2014 · 4 comments

go/parser: TestErrors not re-entrant #9025

gpaul opened this issue Oct 30, 2014 · 4 comments


Copy link

@gpaul gpaul commented Oct 30, 2014

What does 'go version' print?
go version go1.4beta1 linux/amd64

What steps reproduce the problem?
go test go/parser -test.cpu=4,4,4

What happened?
--- FAIL: TestErrors-4 (0.00s)
panic: testdata/commas.src used multiple times [recovered]
    panic: testdata/commas.src used multiple times

goroutine 18 [running]:
    /home/gustav/go.tip/src/testing/testing.go:441 +0x181
go/parser.func·004(0xc208046b40, 0x1)
    /home/gustav/go.tip/src/go/parser/error_test.go:44 +0x10f
go/token.(*FileSet).Iterate(0xc208034440, 0xc2080b5c30)
    /home/gustav/go.tip/src/go/token/position.go:396 +0xb2
go/parser.getFile(0xc208206fc0, 0x13, 0xc2080461e0)
    /home/gustav/go.tip/src/go/parser/error_test.go:49 +0x65
go/parser.expectedErrors(0xc208038000, 0xc208206fc0, 0x13, 0xc208036380, 0x165, 0x365,
    /home/gustav/go.tip/src/go/parser/error_test.go:78 +0x7d
go/parser.checkErrors(0xc208038000, 0xc208206fc0, 0x13, 0x0, 0x0)
    /home/gustav/go.tip/src/go/parser/error_test.go:165 +0x3eb
    /home/gustav/go.tip/src/go/parser/error_test.go:179 +0x471
testing.tRunner(0xc208038000, 0x67f500)
    /home/gustav/go.tip/src/testing/testing.go:447 +0xbf
created by testing.RunTests
    /home/gustav/go.tip/src/testing/testing.go:555 +0xa8b

goroutine 1 [chan receive]:
testing.RunTests(0x5f4518, 0x67f500, 0xd, 0xd, 0x681d01)
    /home/gustav/go.tip/src/testing/testing.go:556 +0xad6
testing.(*M).Run(0xc208056140, 0x67b9c0)
    /home/gustav/go.tip/src/testing/testing.go:485 +0x6c
    go/parser/_test/_testmain.go:82 +0x1d5
FAIL    go/parser   0.022s

What should have happened instead?
=== RUN TestErrors-2
--- PASS: TestErrors-2 (0.00s)
Copy link

@ianlancetaylor ianlancetaylor commented Oct 30, 2014

Comment 1:

Labels changed: added repo-main, release-go1.5.

Copy link

@griesemer griesemer commented Oct 30, 2014

Comment 2:

Owner changed to @griesemer.

Status changed to Accepted.

Copy link

@gopherbot gopherbot commented Nov 19, 2014

Comment 3:

CL mentions this issue.
Copy link

@griesemer griesemer commented Nov 20, 2014

Comment 4:

This issue was closed by revision e538770.

Status changed to Fixed.

@gpaul gpaul added fixed labels Nov 20, 2014
@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@bradfitz bradfitz removed the release-go1.5 label Dec 16, 2014
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.