Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: certFiles needs updating for Solaris 11.2+ #9078

Closed
gopherbot opened this issue Nov 9, 2014 · 4 comments
Closed

crypto/x509: certFiles needs updating for Solaris 11.2+ #9078

gopherbot opened this issue Nov 9, 2014 · 4 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 9, 2014

by shawn.walker@binarycrusader.com:

What does 'go version' print?

$ go version
go version devel +909ea8374845 Sat Nov 08 17:12:23 2014 -0800 solaris/amd64

What steps reproduce the problem?

$ go get code.google.com/p/go.example/hello

What happened?

x509: failed to load system roots and no roots provided

What should have happened instead?

go get should succeed

Please provide any additional information below:

As of Solaris 11.2, there is now a committed, standard location for a system bundle of
CA certificates.  Adding that location to the list of certFiles in
crypto/x509/root_unix.go and recompiling resolves the problem.

$ hg diff
diff --git a/src/crypto/x509/root_unix.go b/src/crypto/x509/root_unix.go
--- a/src/crypto/x509/root_unix.go
+++ b/src/crypto/x509/root_unix.go
@@ -16,6 +16,7 @@ var certFiles = []string{
    "/etc/ssl/cert.pem",                      // OpenBSD
    "/usr/local/share/certs/ca-root-nss.crt", // FreeBSD/DragonFly
    "/etc/pki/tls/cacert.pem",                // OpenELEC
+   "/etc/certs/ca-certificates.crt",         // Solaris 11.2+
 }
 
 // Possible directories with certificate files; stop after successfully
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Nov 9, 2014

Comment 1 by shawn.walker@binarycrusader.com:

See also issue #6391 (currently closed) where I later discovered this was first mentioned.
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 10, 2014

Comment 2:

Labels changed: added repo-main, release-go1.4.

Owner changed to @ianlancetaylor.

Status changed to Started.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Nov 10, 2014

Comment 3:

CL https://golang.org/cl/172920043 mentions this issue.
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 10, 2014

Comment 4:

This issue was closed by revision cea69d6.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
Fixes golang#9078.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/172920043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
Fixes golang#9078.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/172920043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
Fixes golang#9078.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/172920043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018
Fixes golang#9078.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/172920043
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
Fixes golang#9078.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/172920043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.