Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/dashboard: make builders aware of golang.org/x/... sub-repo paths #9079

Closed
adg opened this issue Nov 9, 2014 · 3 comments
Closed

x/build/dashboard: make builders aware of golang.org/x/... sub-repo paths #9079

adg opened this issue Nov 9, 2014 · 3 comments
Assignees
Milestone

Comments

@adg
Copy link
Contributor

@adg adg commented Nov 9, 2014

The build infrastructure uses old code.google.com paths everywhere in the infrastructure.
This needs to be fixed, but there are a few different strategies:

a) Do the full rename everywhere. This includes a potentially risky mass update of the
build dashboard datastore. The watcher tool will need to updated to use "go
get" to initially fetch repositories instead of "hg clone". The builder
daemons would not need to be updated.

b) Leave the paths as-is in the dashboard datastore, but update the builder daemons to
rewrite the paths before checking out the code. This requires updating all the running
builders, but is the lowest risk approach.

c) Have the dashboard app use the new paths in all its communications with the builders
and watcher, but keep using the old paths in the datastore. This also requires updating
the watcher code. The risk here is that we don't catch all the cases and corrupt the
datastore by accidentally putting in references to the new paths. 

Approach "a' is the hardest but least gross approach. "c" is also
difficult and also the most gross. "b' is kinda gross but also low risk.

I might go ahead with plan B just to get 1.4 out the door, with a view to implementing
plan A further down the track.
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 9, 2014

Comment 1:

CL https://golang.org/cl/174740043 mentions this issue.
@adg
Copy link
Contributor Author

@adg adg commented Nov 11, 2014

Comment 2:

We're in decent shape for Go 1.4. Will circle back around to this after the release.

Labels changed: added release-go1.5, removed release-go1.4.

@adg adg added accepted labels Nov 11, 2014
@adg adg self-assigned this Nov 11, 2014
OlingCat pushed a commit to Go-zh/tools.old that referenced this issue Dec 12, 2014
…d 'go test'

The dashboard still uses the old "code.google.com/p/go.*" import paths.
Rewrite them to the new "golang.org/x/*" before running 'go get' and 'go test'.

Update golang/go#9079.

LGTM=rsc
R=rsc, bradfitz
CC=golang-codereviews
https://golang.org/cl/174740043
@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@bradfitz bradfitz removed the release-go1.5 label Dec 16, 2014
adg added a commit to golang/build that referenced this issue Jan 21, 2015
…d 'go test'

The dashboard still uses the old "code.google.com/p/go.*" import paths.
Rewrite them to the new "golang.org/x/*" before running 'go get' and 'go test'.

Update golang/go#9079.

LGTM=rsc
R=rsc, bradfitz
CC=golang-codereviews
https://golang.org/cl/174740043
@rsc rsc removed accepted labels Apr 14, 2015
@rsc rsc changed the title go.tools/dashboard: make builders aware of golang.org/x/... sub-repo paths x/build/dashboard: make builders aware of golang.org/x/... sub-repo paths Apr 26, 2015
@rsc rsc added the Builders label Jun 11, 2015
@crawshaw
Copy link
Contributor

@crawshaw crawshaw commented Jul 11, 2015

I believe @adg fixed this by implementing sub-repo builds in the new buildlet infrastructure (see golang/build@234725b).

@crawshaw crawshaw closed this Jul 11, 2015
@golang golang locked and limited conversation to collaborators Jul 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.