Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: Replace errors.New() with error exported variables #9116

Closed
gopherbot opened this issue Nov 17, 2014 · 3 comments
Closed

crypto/tls: Replace errors.New() with error exported variables #9116

gopherbot opened this issue Nov 17, 2014 · 3 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 17, 2014

by edrocksit:

crypto/tls makes heavy use of errors.New() instead of exported error variables. This
requires anyone checking for specific errors to have to do a basic string compare which
is error prone if the error strings crypto/tls uses ever change.

What does 'go version' print?
go1.3.3 windows/amd64

What steps reproduce the problem?
Do something that makes crypto/tls return an error. In my case with the rest api I'm
using approximately 1 of every 30-50 requests returns "remote error: handshake
failure". The only way to test for this and retry is to do a basic string compare.
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 17, 2014

Comment 1:

Labels changed: added repo-main, release-none.

@gopherbot gopherbot added new labels Nov 17, 2014
@bradfitz bradfitz removed the new label Dec 18, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed release-none labels Apr 10, 2015
@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Aug 25, 2016

CL https://golang.org/cl/27711 mentions this issue.

@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Oct 3, 2017

@ianlancetaylor / @rsc - From the CL above, it seems this idea was abandoned. I believe this issue can be closed then.

@davecheney davecheney closed this Oct 3, 2017
@golang golang locked and limited conversation to collaborators Oct 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.