New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: include $a and $t symbols in arm final link #9118

Open
randall77 opened this Issue Nov 17, 2014 · 2 comments

Comments

Projects
None yet
4 participants
@randall77
Contributor

randall77 commented Nov 17, 2014

The host objdump -d doesn't work correctly on 5l-linked binaries.  5l does not add $a
(arm) and $t (thumb) symbols to the output, and thus objdump doesn't know how to
disassemble the code.  It ends up disassembling as .word directives instead of actual
disassembly.

objdump can be forced to disassemble correctly using -D, but then you get data sections
disassembled into junk.  Or you can use go tool objdump, which works but can't
disassemble thumb.
@minux

This comment has been minimized.

Member

minux commented Nov 18, 2014

Comment 1:

right, and cmd/ld/ldelf.c even filter out existing $a/$d/$t symbols from ELF files.
we not only need to generate $a (and $t if we want to support thumb), we also
need to generate $d for embedded constant pools.

Labels changed: added repo-main.

Status changed to Accepted.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014

@bradfitz bradfitz removed the release-go1.5 label Dec 16, 2014

@rsc rsc removed accepted labels Apr 14, 2015

@rsc

This comment has been minimized.

Contributor

rsc commented Jun 8, 2015

I believe it's too late for this to go into Go 1.5.

@rsc rsc modified the milestones: Unplanned, Go1.5 Jun 8, 2015

@rsc rsc changed the title from cmd/5l: include $a and $t symbols in final link to cmd/link: include $a and $t symbols in arm final link Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment