Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/parser: TestValid failing on 1.4rc1 #9130

Closed
gpaul opened this issue Nov 19, 2014 · 3 comments
Closed

go/parser: TestValid failing on 1.4rc1 #9130

gpaul opened this issue Nov 19, 2014 · 3 comments
Milestone

Comments

@gpaul
Copy link
Contributor

@gpaul gpaul commented Nov 19, 2014

Another test that mutates a global and thus fails with -cpu=1,1

$ go test -test.cpu=1,1 -test.run=TestValid go/parser
--- FAIL: TestValid (0.00s)
panic: package p
 used multiple times [recovered]
    panic: package p
 used multiple times

goroutine 6 [running]:
testing.func·006()
    /home/gustav/go.tip/src/testing/testing.go:441 +0x181
go/parser.func·004(0xc208035200, 0x1)
    /home/gustav/go.tip/src/go/parser/error_test.go:44 +0x10f
go/token.(*FileSet).Iterate(0xc208046480, 0xc208081d28)
    /home/gustav/go.tip/src/go/token/position.go:396 +0xb2
go/parser.getFile(0x5b5a30, 0xa, 0xc2080341e0)
    /home/gustav/go.tip/src/go/parser/error_test.go:49 +0x65
go/parser.expectedErrors(0xc20803a090, 0x5b5a30, 0xa, 0xc208094100, 0xa, 0x10,
0xc208065100)
    /home/gustav/go.tip/src/go/parser/error_test.go:78 +0x7d
go/parser.checkErrors(0xc20803a090, 0x5b5a30, 0xa, 0x52d9c0, 0xc2080940f0)
    /home/gustav/go.tip/src/go/parser/error_test.go:165 +0x3eb
go/parser.TestValid(0xc20803a090)
    /home/gustav/go.tip/src/go/parser/short_test.go:47 +0xfd
testing.tRunner(0xc20803a090, 0x680608)
    /home/gustav/go.tip/src/testing/testing.go:447 +0xbf
created by testing.RunTests
    /home/gustav/go.tip/src/testing/testing.go:555 +0xa8b

goroutine 1 [chan receive]:
testing.RunTests(0x5f4ef8, 0x680500, 0xd, 0xd, 0x682d01)
    /home/gustav/go.tip/src/testing/testing.go:556 +0xad6
testing.(*M).Run(0xc208056140, 0x67c9c0)
    /home/gustav/go.tip/src/testing/testing.go:485 +0x6c
main.main()
    go/parser/_test/_testmain.go:82 +0x1d5
FAIL    go/parser   0.003s
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 19, 2014

Comment 1:

Labels changed: added repo-main, release-go1.4maybe.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 19, 2014

Comment 2:

CL https://golang.org/cl/180920043 mentions this issue.
@griesemer
Copy link
Contributor

@griesemer griesemer commented Nov 20, 2014

Comment 3:

This issue was closed by revision e538770.

Status changed to Fixed.

@gpaul gpaul added fixed labels Nov 20, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.