Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http, time: Wapper Timer with sync.Pool will improve proformace of transport 20% more. #9170

Closed
gopherbot opened this issue Nov 26, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@gopherbot
Copy link

commented Nov 26, 2014

by stormgbs:

go version: go1.3.3 linux/amd64

What does 'go version' print?

I am doing prefomace optimization for gorouter. 
1. The avg qps of gorouter is about 13000 without ResponseHeaderTimeout disabled.
2. The avg qps of gorouter is about 15500 with ResponseHeaderTimeout disabled.
3. I found that time.After() in net/http:tranport.go consumed an unwieldy amount of
memory after finishing pprof.
4. The avg qps of gorouter beccame about 15500 again after I finished wapper Timer wich
sync.Pool.

sync.Pool is prefect.

The patches are attached.

Attachments:

  1. sleep.go.patch (1177 bytes)
  2. transport.go.path (1193 bytes)
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2014

Comment 1:

Please send changes using the process described at
http://golang.org/doc/contribute.html, not via the issue tracker.  But please wait until
after the 1.4 release, which should occur in the next week or two.  Thanks.

Status changed to WontFix.

@gopherbot gopherbot added the wontfix label Nov 26, 2014

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.