Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: mksyscall.sh doesn't make socketpair body for zsyscall_linux_amd64.go automatically #919

Closed
mikioh opened this issue Jul 14, 2010 · 5 comments

Comments

@mikioh
Copy link
Contributor

@mikioh mikioh commented Jul 14, 2010

What steps will reproduce the problem?

1. run mkall.sh at $(GOROOT)/src/pkg/syscall
2. run make at $(GOROOT)/src/pkg/syscall
3. got error

What is the expected output?

no compilation errors

What do you see instead?

6g -o _go_.6 str.go exec.go syscall.go syscall_amd64.go syscall_linux.go
syscall_linux_amd64.go zerrors_linux_amd64.go zsyscall_linux_amd64.go
zsysnum_linux_amd64.go ztypes_linux_amd64.go  syscall_unix.go 
syscall_linux.go:372: undefined: socketpair
make: *** [_go_.6] Error 1

What is your $GOOS?  $GOARCH?

GOARCH=amd64
GOOS=linux

Which revision are you using?  (hg identify)

a481e050147b+ tip

Please provide any additional information below.

Looks like there are two reasons for this issue; a) syscall_linux_amd64.go doesn't
contain ``//sys sockaetpair(...)'' prototype, b) mksyscall.sh doesn't take care about
array type return parameter.

% uname -a
Linux vm5 2.6.32-23-generic #37-Ubuntu SMP Fri Jun 11 08:03:28 UTC 2010 x86_64 GNU/Linux

% cat /etc/lsb-release

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=10.04
DISTRIB_CODENAME=lucid
DISTRIB_DESCRIPTION="Ubuntu 10.04 LTS"
@peterGo
Copy link
Contributor

@peterGo peterGo commented Jul 14, 2010

Comment 1:

This is the likely culprit. It patches code instead of generating code using //sys.
Issue  1319042: Added socketpair syscall and net.Socketpair.
@peterGo
Copy link
Contributor

@peterGo peterGo commented Jul 14, 2010

Comment 2:

I'll submit a CL to fix this by using //sys.
http://golang.org/cl/1319042
@peterGo
Copy link
Contributor

@peterGo peterGo commented Jul 14, 2010

Comment 3:

I'll submit a CL to fix this: http://golang.org/cl/1319042
@peterGo
Copy link
Contributor

@peterGo peterGo commented Jul 17, 2010

Comment 4:

Issue  1799042: code review 1799042: Remove zsyscall file edits 
http://golang.org/cl/1799042
@adg
Copy link
Contributor

@adg adg commented Jul 21, 2010

Comment 5:

Status changed to Fixed.

@mikioh mikioh added fixed labels Jul 21, 2010
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.