Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/websocket: support DialTimeout #9198

Closed
CSEMike opened this issue Dec 2, 2014 · 6 comments
Closed

x/net/websocket: support DialTimeout #9198

CSEMike opened this issue Dec 2, 2014 · 6 comments
Milestone

Comments

@CSEMike
Copy link

@CSEMike CSEMike commented Dec 2, 2014

As with net.Dial, websocket should support a timeout during Dial.

Given the existing DialConfig, perhaps the timeout should be expressed there and used if
present, replacing Dial with DialTimeout:

  https://code.google.com/p/go/source/browse/websocket/client.go?repo=net#77
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 2, 2014

Comment 1:

Labels changed: added repo-net, release-none.

@mikioh
Copy link
Contributor

@mikioh mikioh commented Dec 3, 2014

Comment 2:

i'd rather see Dialer struct or similar. once brad's http/2 lands, we may need to
support websocket over http/2 and Dialer struct would also be a useful knob for that.
@CSEMike CSEMike added new labels Dec 3, 2014
@bradfitz bradfitz removed the new label Dec 18, 2014
@mikioh mikioh added repo-net and removed repo-net labels Dec 23, 2014
@mikioh mikioh changed the title x/net/websocket: support DialTimeout websocket: support DialTimeout Jan 4, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed the release-none label Apr 10, 2015
@rsc rsc changed the title websocket: support DialTimeout x/net/websocket: support DialTimeout Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-net label Apr 14, 2015
@CSEMike
Copy link
Author

@CSEMike CSEMike commented May 24, 2015

A Dialer seems preferable. As it is, there's no way to Dial a domain socket, which is another limitation I've hit.

Is there anyone who can approve a patch to add a Dialer to the Config?

@CSEMike
Copy link
Author

@CSEMike CSEMike commented May 25, 2015

Although, one can dial manually and pass the conn to NewClient, which seems a fine workaround. Perhaps a Dialer is not needed whatsoever.

@nightlyone
Copy link
Contributor

@nightlyone nightlyone commented May 27, 2015

I would prefer passing a net.Conn over using a Dialer too. Otherwise those clients are hard to use in tests.

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 14, 2015

CL https://golang.org/cl/12191 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.