Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: need a "mentions this issue" bot #9303

Closed
bradfitz opened this issue Dec 13, 2014 · 4 comments

Comments

Projects
None yet
6 participants
@bradfitz
Copy link
Member

commented Dec 13, 2014

Because we're using Gerrit, we're not getting Github's normal "mentions this issue" references on the Issue Tracker when a commit referencing "Fixes #nnnn" is pushed to Gerrit.

Are we going to have a bot provide this, like we did on code.google.com?

/cc @adg, @rsc

@adg

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2014

Russ wrote the original bot. Not sure how hard/easy gerrit is to poll,
compared to rietveld.

On 13 December 2014 at 18:37, Brad Fitzpatrick notifications@github.com
wrote:

Because we're using Gerrit, we're not getting Github's normal "mentions
this issue" references on the Issue Tracker when a commit referencing
"Fixes #nnnn" is pushed to Gerrit.

Are we going to have a bot provide this, like we did on code.google.com?

/cc @adg https://github.com/adg, @rsc https://github.com/rsc


Reply to this email directly or view it on GitHub
#9303.

@minux

This comment has been minimized.

Copy link
Member

commented Dec 14, 2014

I just found out that if you use "git clone --mirror" to clone the official repo,
you will find every single active CL in packed-refs file with every revision
available.

For example,
cf348fb refs/changes/00/1200/1
8eb8b40 refs/changes/00/1200/2
69ab69c refs/changes/00/1400/1
661d1da refs/changes/00/1400/2
afc2890 refs/changes/00/1400/3
0cc6d18 refs/changes/00/1500/1

Looking for all commits in refs/changes namespace, and then "git cat-file -p"
each commit.

You don't even need to use Gerrit API for this.

@minux

This comment has been minimized.

Copy link
Member

commented Dec 14, 2014

Interestingly, those orphaned commits are also present in the github mirror.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@josharian

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2015

This got done.

@josharian josharian closed this Jul 22, 2015

@mikioh mikioh changed the title review: need a "mentions this issue" bot x/build: need a "mentions this issue" bot Jul 23, 2015

@golang golang locked and limited conversation to collaborators Aug 5, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.