-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/review/git-codereview: doesn't set upstream to origin/master #9377
Comments
Ah, it seems git is bits old. So |
Hmm? [branch]@{upstream} is supported since git 1.7.0, which is almost 4 years old: https://github.com/git/git/blob/e923eaeb901ff056421b9007adcbbce271caa7b6/Documentation/RelNotes-1.7.0.txt#L104. Based on the bug reports we've gotten over the last few days, regarding these, I'd say we probably support git 1.8+ and we plan to add support to the default git that comes with different OS, see #9283 |
Sorry, I was thrown off by your second comment. |
CL https://golang.org/cl/13600 mentions this issue. |
Strange that I had to revert cl/13600 to make it work on my windows (Windows7 Professional) $ git sync $ git --version |
Is it because of git version difference? I am reopening this issue. |
I'm using git on cmd.exe. Are you using on bash or zsh on msys2? |
I have the same experience as @hyangah. I have a fresh install of git on Windows.
After removing the call to I see the same behavior from both cmd.exe and Git Bash (msys). |
Hmm, strange. I can't reproduce. |
Ah, ooops. Sorry. It seems that I installed two version of git.
1.9.5.msysgit.1 still have problem. I'll make CL for revert. |
Or do you have any idea to support 1.9.5 on windows? for example, checking versions. |
I think we're better off just requiring a newer version of Git. |
That is curious. I get a slightly different version string:
I wonder if that is significant. I downloaded Git from http://git-scm.com/download/win. |
I installed git from msys2 with following.
|
How about to escape like below? argv := []string{"git", "rev-parse", "--abbrev-ref", b.Name + "@\\{u\\}"} |
We need to set upstream to master like below.
The text was updated successfully, but these errors were encountered: