x/review/git-codereview: doesn't set upstream to origin/master

[mattn]

We need to set upstream to master like below.

$ git checkout -b fix-windows-readlink
$ vim foo.go
$ git change
git rev-parse --abbrev-ref fix-windows-readlink@{u}
error: No upstream branch found for 'fix-windows-readlink'
error: No upstream branch found for 'fix-windows-readlink'
fatal: ambiguous argument 'fix-windows-readlink@{u}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions
fix-windows-readlink@{u}

git branch --set-upstream fix-windows-readlink origin/master

[mattn]

Ah, it seems git is bits old. So @{u} make an error on git 1.7 .
What version of git are supported?

[paranoiacblack]

Hmm? [branch]@{upstream} is supported since git 1.7.0, which is almost 4 years old: https://github.com/git/git/blob/e923eaeb901ff056421b9007adcbbce271caa7b6/Documentation/RelNotes-1.7.0.txt#L104.

Based on the bug reports we've gotten over the last few days, regarding these, I'd say we probably support git 1.8+ and we plan to add support to the default git that comes with different OS, see #9283

[mattn]

really?

[paranoiacblack]

Sorry, I was thrown off by your second comment. [branch]@{u} is supported since git 1.7.0. The problem is that git checkout -b doesn't set an upstream, you'd need to run git checkout -b [branch] --track origin/master if you are not creating branches with git review change. I'm not sure if git review change should try to correct this for you or not.

[mattn]

https://go-review.googlesource.com/#/c/13600/

[gopherbot]

CL https://golang.org/cl/13600 mentions this issue.