Skip to content

x/review/git-codereview: commit-msg hook doesn't play well with Signed-off-by lines #9385

@minux

Description

@minux

For example, git commit -s will generate this log message:

    test: test commit

    Signed-off-by: Shenghou Ma <minux@golang.org>

    Change-Id: I3545610fc076ab9da46bb5ed571a49730a5075dc

However, it should look this instead, which is generated by the official gerrit commit-msg hook:

    test: test commit

    Change-Id: I3545610fc076ab9da46bb5ed571a49730a5075dc    
    Signed-off-by: Shenghou Ma <minux@golang.org>

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions