New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: warn about assembly functions using fully qualified name #9548

Open
josharian opened this Issue Jan 9, 2015 · 1 comment

Comments

Projects
None yet
4 participants
@josharian
Contributor

josharian commented Jan 9, 2015

See golang.org/cl/2588 for a full description.

cc @minux

@mikioh mikioh added the repo-tools label Jan 10, 2015

@mikioh mikioh changed the title from tools/cmd/vet: warn about assembly functions using fully qualified name to cmd/vet: warn about assembly functions using fully qualified name Jan 10, 2015

@minux

This comment has been minimized.

Member

minux commented Jan 11, 2015

only warn if GO_ARGS is present or if argument size > 0?

additionally, i think cmd/vet should warn if the frame size > 0 but
no NO_LOCAL_POINTERS in the body.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title from cmd/vet: warn about assembly functions using fully qualified name to x/tools/cmd/vet: warn about assembly functions using fully qualified name Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc removed the repo-tools label Apr 14, 2015

@mvdan mvdan changed the title from x/tools/cmd/vet: warn about assembly functions using fully qualified name to cmd/vet: warn about assembly functions using fully qualified name May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment