runtime: background goroutines show up in early failures #9791

Closed
rsc opened this Issue Feb 6, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@rsc
Contributor

rsc commented Feb 6, 2015

I don't ever want to see these goroutines.
We used to mark them as system goroutines while creating them.
Now they get marked as system when they start running, so there is a race: if the failure happens before they get a chance to run, they show up.

We need to get rid of the race.

g% new6g
panic: flag

goroutine 1 [running]:
cmd/internal/obj.Flagcount(0x2a0f50, 0x1, 0x2d1c70, 0x11, 0x421c30)
/Users/rsc/g/go/src/cmd/internal/obj/flag.go:7 +0x64
cmd/internal/gc.Main()
/Users/rsc/g/go/src/cmd/internal/gc/lex.go:178 +0xcdd
main.main()
/Users/rsc/g/go/src/cmd/new6g/galign.go:108 +0x56a

goroutine 2 [runnable]:
runtime.forcegchelper()
/Users/rsc/g/go/src/runtime/proc.go:111
runtime.goexit()
/Users/rsc/g/go/src/runtime/asm_amd64.s:2454 +0x1

goroutine 3 [runnable]:
runtime.runfinq()
/Users/rsc/g/go/src/runtime/mfinal.go:115
runtime.goexit()
/Users/rsc/g/go/src/runtime/asm_amd64.s:2454 +0x1
g%

@rsc rsc added this to the Go1.5 milestone Feb 6, 2015

@dvyukov dvyukov closed this in 59495e8 Feb 11, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

LK4D4 referenced this issue in LK4D4/gopheracademy-web Nov 11, 2016

advent-2016: timers in Go
Article for Advent 2016 event about timers in Go. Timers include
time.Sleep, time.Timer and time.Ticker.

Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.