net/http: default User-Agent is invalid

[etoews]

The default User-Agent

Go 1.1 package http

in the http package doesn't appear to be valid according to the User-Agent section of RFC 7231.

Go should have a properly formatted User-Agent. e.g.

Go-http/1.1

[sigmavirus24]

Also, since it seems like "1.1" might be the version of Go not the package, it might make sense to do something like

Go-1.1-http-package/{package-version}

But I'm not sure if there is a version for standard packages.

[bradfitz]

I've never had opinions on this. I believe @rsc picked this string on purpose.

[rsc]

I have never seen anything about user-agent syntax before. Sorry.

[syst3mw0rm]

Here's the proposed fix - https://go-review.googlesource.com/#/c/9385/

[gopherbot]

CL https://golang.org/cl/9385 mentions this issue.

[bradfitz]

I would like to put the Go version number in the User-Agent. Perhaps we only include it if it's not a dev release? So go-package-http/1.5 or go-package-http/dev but never go-package-http/GITCOMMITHASH. @rsc, thoughts?

[syst3mw0rm]

I agree with @bradfitz to not include the GITCOMMITHASH.