Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: giggabyte #9814

Closed
alicebob opened this issue Feb 9, 2015 · 1 comment
Closed

cmd/pprof: giggabyte #9814

alicebob opened this issue Feb 9, 2015 · 1 comment
Milestone

Comments

@alicebob
Copy link
Contributor

@alicebob alicebob commented Feb 9, 2015

pprof has this case statement:

case "gb", "gbyte", "giggabyte":

https://github.com/golang/go/blob/master/src/cmd/pprof/internal/report/report.go#L1534

How many bytes go in a gigga?

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 9, 2015

@rsc, are we allowed to modify pprof in our tree, or is there an upstream we should fix first and then pull down?

@bradfitz bradfitz added this to the Go1.5Maybe milestone Feb 9, 2015
@mikioh mikioh changed the title giggabyte cmd/pprof: giggabyte Feb 9, 2015
@mikioh mikioh modified the milestones: Go1.5Maybe, Go1.5 Feb 24, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.