Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/dashboard: don't show commit hash in the first column #9839

Closed
dvyukov opened this issue Feb 11, 2015 · 4 comments

Comments

@dvyukov
Copy link
Member

commented Feb 11, 2015

@adg @bradfitz

For discussion, because this is based only my usage patterns.

Hash is useful to go to commit page. However, I first need to look at the very right to find the commit, and then visually move to the very left to click on the commit. With the current number of builders this movement is very painful.

Also, the exact characters of the commit hash does not seem to be super important to occupy the first column.

So I propose to linkify commit message to link to the commit page.

If one needs to copy commit hash, then it is possible to do on the commit page. If one strongly wants to be able to copy commit hash right on the dashboard, then I still propose to move it to right, e.g.:
runtime: cache workbufs on Ms and add consistency checks (a15818f)
Because one needs to see commit description to pick the right hash.

@bradfitz bradfitz added the builder label Feb 11, 2015

@bradfitz

This comment has been minimized.

Copy link
Member

commented Feb 11, 2015

SGTM

Or linkify the date instead, so it has bounded width and isn't a sea of blue underlines on the right side.

@dvyukov

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2015

@bradfitz works for me

@adg

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2015

Either approach is fine IMO.

On 11 February 2015 at 17:00, Dmitry Vyukov notifications@github.com
wrote:

@bradfitz https://github.com/bradfitz works for me


Reply to this email directly or view it on GitHub
#9839 (comment).

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title dashboard: don't show commit hash in the first column x/build/dashboard: don't show commit hash in the first column Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc removed the builder label Apr 14, 2015

@rsc rsc added the Builders label Jun 11, 2015

@bradfitz

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

This isn't urgent and nobody feels strongly, so closing this for now. If somebody wants to hack up something prettier and mail it out we'll take a look.

@bradfitz bradfitz closed this Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.