Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/all: allow packages to work with App Engine 'goapp' tool. #9845

Open
ThePiachu opened this issue Feb 11, 2015 · 2 comments

Comments

@ThePiachu
Copy link

commented Feb 11, 2015

This issue relates at least to the go.crypto packages, but probably more packages are also relevant.

Google app Engine can't assamble *.s files, so any GAE app that uses this library won't be able to run tests for example, due to "no such tool 6a". Relevant discussion - btcsuite/fastsha256#2 .

The fix for this issue is simple - it consists of adding one flag to all .s files:

// +build !appengine

@mikioh mikioh added the repo-crypto label Feb 15, 2015

@mikioh mikioh changed the title go.crypto - Allow package to work with App Engine 'goapp' tool. all: allow packages to work with App Engine 'goapp' tool. Feb 15, 2015

bradfitz added a commit to golang/crypto that referenced this issue Mar 27, 2015
poly1305, curve25519: add build constraints for appengine
Updates: golang/go#9845

Change-Id: I78ce460d2a188ee13dd3f80015919a14eba03d07
Reviewed-on: https://go-review.googlesource.com/8100
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title all: allow packages to work with App Engine 'goapp' tool. x/crypto/all: allow packages to work with App Engine 'goapp' tool. Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc removed the repo-crypto label Apr 14, 2015

@DemiMarie

This comment has been minimized.

Copy link

commented Jan 22, 2016

This could create a side channel vulnerability

@minux

This comment has been minimized.

Copy link
Member

commented Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.