-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: display ops/s #9850
Comments
Are you referring to the benchmarks in $GOROOT/test/bench, the testing package's benchmarking feature, or something else? |
I think the OP means benchmarks using the testing package.
|
derp, there we go haha. Yeah just the test -bench output. I'm almost always curious what the ops/s are and manually converting over from nano so it gets a little awkward when you do that reasonably often. |
@tj What about writing a simple wrapper for that and share it in some repository? See https://github.com/golang/tools/blob/master/benchmark/parse/parse.go on how to parse benchmark output. I guess this parser will be maintained for quite some time, since https://github.com/golang/tools/blob/master/cmd/benchcmp relies on it. |
@nightlyone hmm I'm not opposed to it, but with the general out-of-the-box experience Go provides it seems a little odd to me. If we went that route maybe a json output flag makes more sense, so it's not such an ad-hoc format to parse? That would be handy for CI too |
JSON output might be useful, but in the meantime one can use |
I wouldn't be opposed to a flag to switch the output. cc @robpike On 13 February 2015 at 08:19, Dominik Honnef notifications@github.com
|
Adding -json for go test and the testing package is #2981.
|
Nice, interfaces would definitely be better in this case, wrapping the exec is pretty extreme for one metric. I'll close this and see if I can get time to get a patch for that other issue |
Most people obviously feel differently :D but I think it would be nice, even if it's a flag. Almost everything we evaluate is tied back to metrics that are already reported as ops/s in various tools.
The text was updated successfully, but these errors were encountered: