Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: Update docstring for Format in format.go #10962

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@AlexFinkel
Copy link

commented May 26, 2015

The reference time described in the docstring for Format doesn't provide a value for nanoseconds. This hides the functionality provided by the Format function to render milli, micro and nanoseconds.

This has led to some confusion that Format can't handle sub-second precision: https://groups.google.com/forum/#!topic/golang-nuts/TIinEnPu5wE

Update docstring for Format in format.go
The reference time described in the docstring for Format doesn't provide a value for nanoseconds. This hides the functionality provided by the Format function to render milli, micro and nanoseconds.

This has led to some confusion that Format can't handle sub-second precision: https://groups.google.com/forum/#!topic/golang-nuts/TIinEnPu5wE
@adg

This comment has been minimized.

Copy link
Contributor

commented May 26, 2015

Hi, please note that we don't take pull requests, but rather use a different code review system. See https://golang.org/doc/contribute.html

As for this particular issue, I'm not sure this fix is correct. Please file an issue so we can discuss the right fix. Thanks.

@adg adg closed this May 26, 2015

@AlexFinkel

This comment has been minimized.

Copy link
Author

commented May 26, 2015

Thanks for letting me know adg, filed issue #10963.

@mikioh mikioh changed the title Update docstring for Format in format.go time: Update docstring for Format in format.go May 27, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.