Skip to content

src/testing/cover: document the CoverBlock struct fields #24079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
steuhs wants to merge 3 commits into from
Closed

src/testing/cover: document the CoverBlock struct fields #24079

steuhs wants to merge 3 commits into from

Conversation

@steuhs
Copy link
Contributor

@steuhs steuhs commented Feb 23, 2018 •
edited by andybons
Loading

Fill in the missing descriptions for the CoverBlock struct fields

@steuhs
missing discription for CoverBlock struct
9234df0 
fill in the missing discription for CoverBlock struct
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 23, 2018
@gopherbot
Copy link
Contributor

gopherbot commented Feb 23, 2018

This PR (HEAD: 9234df0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/96756 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Feb 23, 2018

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 23, 2018

Message from Brad Fitzpatrick:

Patch Set 1:

This commit message needs work.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@steuhs steuhs changed the title missing discription for CoverBlock struct src/testing/cover: missing discription for CoverBlock struct Feb 23, 2018
@gopherbot
Copy link
Contributor

gopherbot commented Feb 26, 2018

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Feb 28, 2018

Message from Andrew Bonventre:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 2 times, most recently from a8a60ac to 87412a1 Compare May 6, 2018 04:30
@gopherbot gopherbot force-pushed the master branch 3 times, most recently from e4259d6 to 6dbaf03 Compare May 31, 2018 18:23
@agnivade
Copy link
Contributor

agnivade commented Jun 9, 2018

ping @steuhs - Please take a look at the review comments :)

@steuhs steuhs changed the title src/testing/cover: missing discription for CoverBlock struct src/testing/cover: document the CoverBlock struct fields Jun 11, 2018
@gopherbot
Copy link
Contributor

gopherbot commented Jun 11, 2018

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 11, 2018

This PR (HEAD: 8f165e3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/96756 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jun 11, 2018

This PR (HEAD: f5b9e1d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/96756 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jun 11, 2018

Message from Stephen Lu:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 29, 2018

Message from Gerrit Bot:

Uploaded patch set 6: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 29, 2018

Message from Andrew Bonventre:

Patch Set 6: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 29, 2018

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=00d5eaea

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 29, 2018

Message from Brad Fitzpatrick:

Patch Set 6:

Drop leading src/ in commit message

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 29, 2018

Message from Gobot Gobot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96756.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jun 29, 2018

This PR is being closed because golang.org/cl/96756 has been merged.

@gopherbot gopherbot closed this Jun 29, 2018
gopherbot pushed a commit that referenced this pull request Jun 29, 2018
@steuhs @andybons
src/testing/cover: document the CoverBlock struct fields
57da8dd 
Fill in the missing descriptions for the CoverBlock struct fields

Change-Id: I9257881a19b01e5cfe61cf19a91375b6d7cc68ef
GitHub-Last-Rev: f5b9e1d
GitHub-Pull-Request: #24079
Reviewed-on: https://go-review.googlesource.com/96756
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@steuhs @gopherbot @agnivade @googlebot