New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cover: add index page of coverage reports #25267

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@kt3k
Copy link

kt3k commented May 6, 2018

This change adds the index page of coverage reports. You can move around
the report pages as in usual web sites.

details:

  • I added CoverageClass string field to templateFile struct, which represent the class name (cov0 - cov10) depending on the coverage percent.
  • I removed the select box in #topbar, instead added the index page (#index) and .breadcrumb, so that you can move around the reports by clicking the links to each page.
  • I added the hashchange listener to the window object and it triggers the virtual page transitions.
  • I added various css classes for styling purpose.

demo page

screenshots:

2018-05-06 17 48 47

2018-05-06 17 48 59

cmd/cover: add index page of coverage reports
This change adds the index page of coverage reports. You can move around
the report pages as in usual web sites.

Change-Id: I80ad8c34e2b96ab9a2a82dcace83ef20922b5b03

@googlebot googlebot added the cla: yes label May 6, 2018

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 6, 2018

This PR (HEAD: 8360819) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/111647 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 6, 2018

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/111647.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 8, 2018

Message from Ian Lance Taylor:

Patch Set 1:

R=go1.12

Not sure who should review this. Normally we discuss new features before implementing them.


Please don’t reply on this GitHub thread. Visit golang.org/cl/111647.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 10, 2018

Message from Yoshiya Hinosawa:

Patch Set 1:

Should I open an issue for discussing this feature?


Please don’t reply on this GitHub thread. Visit golang.org/cl/111647.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 10, 2018

Message from Ian Lance Taylor:

Patch Set 1:

Should I open an issue for discussing this feature?

Sure, thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/111647.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 15, 2018

Message from Yoshiya Hinosawa:

Patch Set 1:

Created an issue for this: #25368


Please don’t reply on this GitHub thread. Visit golang.org/cl/111647.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the golang:master branch 2 times, most recently from e4259d6 to 6dbaf03 May 31, 2018

@kt3k kt3k closed this Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment