Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Aug 10, 2018

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Aug 10, 2018
@seratch
Copy link
Contributor Author

seratch commented Aug 10, 2018

I just signed the CLA.
screen shot 2018-08-10 at 23 43 27

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Aug 10, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 1:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@seratch
Copy link
Contributor Author

seratch commented Aug 11, 2018

I've removed the markdown part from the description. To keep it visible, let me paste the part here:

before

$ misspell . | grep -v .txt | grep -v '"rela"' | grep -v '"RELA"' | grep -v '"Rela"' | grep -v ONOT | grep -v '/vendor/' | grep -v entity.go | grep -v src/mime/quotedprintable/writer_test.go | grep -v Faught | grep -v misc/trace/trace_viewer_full.html
doc/devel/weekly.html:1832:30: "explicity" is a misspelling of "explicitly"
doc/devel/weekly.html:3441:26: "implementating" is a misspelling of "implementation"
doc/devel/weekly.html:3779:29: "pacakge" is a misspelling of "package"
misc/cgo/test/issue9400_linux.go:44:40: "assmebly" is a misspelling of "assembly"
misc/cgo/testshared/shared_test.go:563:22: "depedency" is a misspelling of "dependency"
src/bytes/buffer_test.go:296:41: "emtpy" is a misspelling of "empty"
src/cmd/asm/internal/asm/operand_test.go:36:63: "occured" is a misspelling of "occurred"
src/cmd/asm/internal/asm/testdata/amd64enc_extra.s:914:10: "surpress" is a misspelling of "suppress"
src/cmd/compile/internal/gc/ssa.go:5651:10: "untranslateable" is a misspelling of "untranslatable"
src/cmd/compile/internal/ssa/compile.go:256:1: "alltime" is a misspelling of "all-time"
src/cmd/compile/internal/ssa/compile.go:261:3: "alltime" is a misspelling of "all-time"
src/cmd/compile/internal/ssa/compile.go:315:12: "alltime" is a misspelling of "all-time"
src/cmd/compile/internal/gc/walk.go:3332:1: "nto" is a misspelling of "not"
src/cmd/compile/internal/gc/walk.go:3347:25: "nto" is a misspelling of "not"
src/cmd/compile/internal/gc/walk.go:3357:32: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/deadstore.go:136:66: "acheive" is a misspelling of "achieve"
src/cmd/compile/internal/ssa/gen/generic.rules:515:40: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/gen/generic.rules:515:56: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite.go:343:3: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite.go:344:5: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite.go:943:59: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite.go:952:8: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:9:24: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:12:50: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:15:12: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:16:22: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:28:5: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:34:12: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:35:22: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:81:12: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:82:22: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:5975:19: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:5975:35: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:5986:14: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:5986:30: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:6002:19: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:6002:35: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:6013:14: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:6013:30: "nto" is a misspelling of "not"
src/cmd/go/internal/cache/default_unix_test.go:65:17: "initalization" is a misspelling of "initialization"
src/cmd/go/alldocs.go:1798:61: "correponding" is a misspelling of "corresponding"
src/cmd/go/internal/modfetch/proxy.go:58:58: "correponding" is a misspelling of "corresponding"
src/cmd/go/internal/modload/load.go:675:44: "conatins" is a misspelling of "contains"
src/cmd/go/internal/work/exec.go:2861:18: "excercise" is a misspelling of "exercise"
src/cmd/trace/goroutines.go:169:17: "dividened" is a misspelling of "dividend"
src/cmd/trace/goroutines.go:173:55: "dividened" is a misspelling of "dividend"
src/cmd/trace/goroutines.go:175:16: "dividened" is a misspelling of "dividend"
src/cmd/trace/goroutines.go:179:53: "dividened" is a misspelling of "dividend"
src/cmd/trace/annotations.go:442:22: "decendents" is a misspelling of "descendants"
src/cmd/trace/annotations.go:1162:17: "dividened" is a misspelling of "dividend"
src/cmd/trace/annotations.go:1166:55: "dividened" is a misspelling of "dividend"
src/cmd/trace/annotations.go:1168:16: "dividened" is a misspelling of "dividend"
src/cmd/trace/annotations.go:1172:53: "dividened" is a misspelling of "dividend"
src/crypto/aes/gcm_arm64.s:437:12: "intial" is a misspelling of "initial"
src/crypto/aes/gcm_arm64.s:736:12: "intial" is a misspelling of "initial"
src/crypto/aes/gcm_arm64.s:972:55: "presense" is a misspelling of "presence"
src/crypto/x509/verify.go:864:68: "accomodate" is a misspelling of "accommodate"
src/internal/bytealg/index_arm64.s:35:48: "comparsion" is a misspelling of "comparison"
src/internal/trace/goroutines.go:40:23: "explicitely" is a misspelling of "explicitly"
src/os/user/user.go:14:12: "overriden" is a misspelling of "overridden"
src/runtime/asm_amd64.s:1468:48: "demonstates" is a misspelling of "demonstrates"
src/runtime/sys_windows_amd64.s:366:25: "inital" is a misspelling of "initial"
src/time/time.go:1079:26: "representating" is a misspelling of "representation"
test/fixedbugs/issue22662b.go:21:37: "preceeding" is a misspelling of "preceding"
test/live.go:468:15: "choosen" is a misspelling of "chosen"
test/run.go:438:60: "libary" is a misspelling of "library"

after

$ misspell . | grep -v .txt | grep -v '"rela"' | grep -v '"RELA"' | grep -v '"Rela"' | grep -v ONOT | grep -v '/vendor/' | grep -v entity.go | grep -v src/mime/quotedprintable/writer_test.go | grep -v Faught | grep -v misc/trace/trace_viewer_full.html
src/cmd/compile/internal/ssa/compile.go:256:1: "alltime" is a misspelling of "all-time"
src/cmd/compile/internal/ssa/compile.go:261:3: "alltime" is a misspelling of "all-time"
src/cmd/compile/internal/ssa/compile.go:315:12: "alltime" is a misspelling of "all-time"
src/cmd/compile/internal/gc/walk.go:3332:1: "nto" is a misspelling of "not"
src/cmd/compile/internal/gc/walk.go:3347:25: "nto" is a misspelling of "not"
src/cmd/compile/internal/gc/walk.go:3357:32: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/gen/generic.rules:515:40: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/gen/generic.rules:515:56: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite.go:343:3: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite.go:344:5: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite.go:943:59: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite.go:952:8: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:9:24: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:12:50: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:15:12: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:16:22: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:28:5: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:34:12: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:35:22: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:81:12: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewrite_test.go:82:22: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:5975:19: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:5975:35: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:5986:14: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:5986:30: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:6002:19: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:6002:35: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:6013:14: "nto" is a misspelling of "not"
src/cmd/compile/internal/ssa/rewritegeneric.go:6013:30: "nto" is a misspelling of "not"
src/cmd/trace/goroutines.go:169:17: "dividened" is a misspelling of "dividend"
src/cmd/trace/goroutines.go:173:55: "dividened" is a misspelling of "dividend"
src/cmd/trace/goroutines.go:175:16: "dividened" is a misspelling of "dividend"
src/cmd/trace/goroutines.go:179:53: "dividened" is a misspelling of "dividend"
src/cmd/trace/annotations.go:443:22: "decendents" is a misspelling of "descendants"
src/cmd/trace/annotations.go:1163:17: "dividened" is a misspelling of "dividend"
src/cmd/trace/annotations.go:1167:55: "dividened" is a misspelling of "dividend"
src/cmd/trace/annotations.go:1169:16: "dividened" is a misspelling of "dividend"
src/cmd/trace/annotations.go:1173:53: "dividened" is a misspelling of "dividend"

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 3:

The commit message is still wrong. See the last link.

The commit message comes from your PR description.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 5: New patch set was added with same tree, parent, and commit message as Patch Set 4.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 5:

See the link I sent. You need to edit the PR's title & description.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@seratch seratch changed the title Fix typos detected by github.com/client9/misspell all: fix typos detected by github.com/client9/misspell Aug 11, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 6: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 7: New patch set was added with same tree, parent, and commit message as Patch Set 6.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 8: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 9: New patch set was added with same tree, parent, and commit message as Patch Set 8.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 9:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 11: New patch set was added with same tree, parent, and commit message as Patch Set 10.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28709:

Patch Set 10:

(3 comments)

Patch Set 9:

(2 comments)

Thank you for your review. I've fixed the two parts to be addressed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5206:

Patch Set 11:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 13: New patch set was added with same tree, parent, and commit message as Patch Set 12.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28709:

Patch Set 11:

(1 comment)

I've fixed the line you pointed out. Thank you for that.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 14: Patch Set 13 was rebased


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 14: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 14:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=eb866297


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 14: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/128955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/128955 has been merged.

@gopherbot gopherbot closed this Aug 23, 2018
gopherbot pushed a commit that referenced this pull request Aug 23, 2018
Change-Id: Iadb3c5de8ae9ea45855013997ed70f7929a88661
GitHub-Last-Rev: ae85bcf
GitHub-Pull-Request: #26920
Reviewed-on: https://go-review.googlesource.com/128955
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
JackOfMostTrades pushed a commit to JackOfMostTrades/go-crypto that referenced this pull request Feb 3, 2019
Change-Id: Iadb3c5de8ae9ea45855013997ed70f7929a88661
GitHub-Last-Rev: ae85bcf82be8fee533e2b9901c6133921382c70a
GitHub-Pull-Request: golang/go#26920
Reviewed-on: https://go-review.googlesource.com/128955
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
bassosimone pushed a commit to ooni/oocrypto that referenced this pull request May 21, 2022
Change-Id: Iadb3c5de8ae9ea45855013997ed70f7929a88661
GitHub-Last-Rev: ae85bcf82be8fee533e2b9901c6133921382c70a
GitHub-Pull-Request: golang/go#26920
Reviewed-on: https://go-review.googlesource.com/128955
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants