New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: fix typo in the SameSite docs #28302

Closed

mbj36 wants to merge 1 commit into golang:master from mbj36:master

Contributor

mbj36 commented Oct 22, 2018

Fixes #28244


          doc: fix typo in cookie.go

83b16fa

googlebot added the cla: yes label

gopherbot commented Oct 22, 2018

This PR (HEAD: 83b16fa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/143480 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

9 similar comments

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 22, 2018

Message from Gerrit User 13550:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Nov 16, 2018

Message from Agniva De Sarker:

Patch Set 1:

ping Mohit ?

Please don’t reply on this GitHub thread. Visit golang.org/cl/143480.
After addressing review feedback, remember to publish your drafts!

Contributor Author

mbj36 commented Nov 16, 2018

@agnivade Do this PR needs any change from my side ?

Contributor

agnivade commented Nov 16, 2018

Yes, as you can see in the CL, this comment is unresolved. Thank you.

bradfitz changed the title ~~doc: fix typo in cookie.go~~ net/http: fix typo in the SameSite docs

gopherbot commented Nov 16, 2018

This PR is being closed because golang.org/cl/143480 has been merged.

gopherbot closed this

gopherbot pushed a commit that referenced this pull request


          net/http: fix typo in the SameSite docs

6557af7

Fixes #28244

Change-Id: I3ca36fd513f5543af0c8af254d267254c7d5e803
GitHub-Last-Rev: 83b16fa
GitHub-Pull-Request: #28302
Reviewed-on: https://go-review.googlesource.com/c/143480
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

bradfitz pushed a commit that referenced this pull request


          net/http: fix typo in the SameSite docs

b1e8846

Fixes #28244

Change-Id: I3ca36fd513f5543af0c8af254d267254c7d5e803
GitHub-Last-Rev: 83b16fa
GitHub-Pull-Request: #28302
Reviewed-on: https://go-review.googlesource.com/c/143480
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment