Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: add Logger.Writer method #28399

Closed
wants to merge 1 commit into from
Closed

log: add Logger.Writer method #28399

wants to merge 1 commit into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@poy @gopherbot @googlebot
@poy
Copy link
Contributor

@poy poy commented Oct 25, 2018 •
edited by bradfitz

Writer method returns the underlying io.Writer used by the given Logger
object.

Fixes #28327
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

This PR (HEAD: 1c23b2d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/144757 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 5015:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@poy poy force-pushed the log-logger-writer-method branch from 1c23b2d to 550d136 Oct 25, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

This PR (HEAD: 550d136) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/144757 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 29751:

Patch Set 2:

Patch Set 1:

(3 comments)

I made the requested updates and amended the commit.

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@bradfitz bradfitz changed the title log: adds Writer method to Logger log: add Logger.Writer method Oct 25, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 5015:

Patch Set 2: Code-Review+2

Thanks for doing this.

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 5065:

Patch Set 2:

Patch Set 2:

Patch Set 1:

(3 comments)

I made the requested updates and amended the commit.

I fixed the PR title & body per the https://github.com/golang/go/wiki/CommitMessage instructions.

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 5015:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 5976:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2f2e92cc

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 5015:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@poy
log: add Writer method to Logger
2db0c5c 
Writer method returns the underlying io.Writer used by the given Logger
object.

Fixes golang#28327
@poy poy force-pushed the log-logger-writer-method branch from 550d136 to 2db0c5c Oct 25, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

This PR (HEAD: 2db0c5c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/144757 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

Message from Gerrit User 5976:

Patch Set 3: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/144757.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this issue Oct 25, 2018
@poy @robpike
log: add Logger.Writer method
51104cd 
Writer method returns the underlying io.Writer used by the given Logger
object.

Fixes #28327

Change-Id: I6347913d8be8d3222b98967b136cf03d00f446d1
GitHub-Last-Rev: 2db0c5c
GitHub-Pull-Request: #28399
Reviewed-on: https://go-review.googlesource.com/c/144757
Reviewed-by: Rob Pike <r@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2018

This PR is being closed because golang.org/cl/144757 has been merged.

@gopherbot gopherbot closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment