Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http/httputil: fix unannounced trailers when body is empty #29032

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@juliens
Copy link
Contributor

commented Nov 30, 2018

Fix unannounced trailers when body is empty and without announced trailers.

Fixes #29031

@googlebot googlebot added the cla: yes label Nov 30, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Nov 30, 2018

This PR (HEAD: 04ca439) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

commented Nov 30, 2018

This PR (HEAD: fc4496b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

commented Nov 30, 2018

Message from Brad Fitzpatrick:

Patch Set 2: Run-TryBot+1 Code-Review+1

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Nov 30, 2018

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a667f18c


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Nov 30, 2018

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Brad Fitzpatrick:

Patch Set 2:

Julien, ping. Can you update this?


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

This PR (HEAD: 399ae85) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@bradfitz bradfitz changed the title net/http/httputil: fix announced trailers when body is empty net/http/httputil: fix unannounced trailers when body is empty Dec 3, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Brad Fitzpatrick:

Patch Set 4: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=4272176b


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@juliens juliens force-pushed the juliens:trailer-fix branch from 399ae85 to 3469adc Dec 3, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

This PR (HEAD: 3469adc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151898 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Gobot Gobot:

Patch Set 4:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/4272176b/freebsd-amd64-12_0_3a9c111c.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Brad Fitzpatrick:

Patch Set 5: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=67948164


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Gobot Gobot:

Patch Set 5:

Build is still in progress...
This change failed on js-wasm:
See https://storage.googleapis.com/go-build-log/67948164/js-wasm_675e888f.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Gobot Gobot:

Patch Set 5: TryBot-Result-1

1 of 19 TryBots failed:
Failed on js-wasm: https://storage.googleapis.com/go-build-log/67948164/js-wasm_675e888f.log

Consult https://build.golang.org/ to see whether they are new failures.


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 3, 2018

net/http/httputil: fix unannounced trailers when body is empty
Fix unannounced trailers when body is empty and without announced trailers.

Fixes #29031

Change-Id: If49951a42fe56d4be4436a999627db4c2678659d
GitHub-Last-Rev: 3469adc
GitHub-Pull-Request: #29032
Reviewed-on: https://go-review.googlesource.com/c/151898
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

Message from Brad Fitzpatrick:

Patch Set 5: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/151898.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Dec 3, 2018

This PR is being closed because golang.org/cl/151898 has been merged.

@gopherbot gopherbot closed this Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.