New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http/httputil: add tests for singleJoiningSlash. #29088

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@desimone
Copy link
Contributor

desimone commented Dec 4, 2018

These changes add tests for the unexported function singleJoiningSlash.

net/http/httputil: adds tests for singleJoiningSlash.
These changes add tests for the unexported function singleJoiningSlash.

@googlebot googlebot added the cla: yes label Dec 4, 2018

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 4, 2018

This PR (HEAD: ed6f86f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/152337 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 4, 2018

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/152337.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 4, 2018

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/152337.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 4, 2018

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=18427999


Please don’t reply on this GitHub thread. Visit golang.org/cl/152337.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 4, 2018

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/152337.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 4, 2018

net/http/httputil: add tests for singleJoiningSlash.
These changes add tests for the unexported function singleJoiningSlash.

Change-Id: I107905aac4a3c2544be309098b67e970ea5b542c
GitHub-Last-Rev: ed6f86f
GitHub-Pull-Request: #29088
Reviewed-on: https://go-review.googlesource.com/c/152337
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 4, 2018

This PR is being closed because golang.org/cl/152337 has been merged.

@gopherbot gopherbot closed this Dec 4, 2018

@desimone desimone deleted the desimone:http-util-add-joining-slash-tests branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment