Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/smtp: add missing error check in test #30018

Conversation

@leonklingele
Copy link
Contributor

leonklingele commented Jan 30, 2019

No description provided.

@googlebot googlebot added the cla: yes label Jan 30, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 30, 2019

This PR (HEAD: c26c315) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/160442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 10, 2019

Message from Emmanuel Odeke:

Patch Set 1: Run-TryBot+1

Thank you Leon! I'll run the trybots and also tag this for Go1.13.

R=Go1.13


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 10, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=25382acb


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 10, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the golang:master branch from aad2336 to 9892cd6 May 14, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jun 26, 2019

Message from Alex Miasoedov:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the golang:master branch from 53bd915 to 6139019 Oct 3, 2019
@gopherbot gopherbot force-pushed the golang:master branch 7 times, most recently from 4a7ed1f to 0f992b9 Nov 5, 2019
@mvdan mvdan force-pushed the leonklingele:net-smtp-add-missing-error-check branch from c26c315 to 67f97d1 Nov 5, 2019
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 5, 2019

This PR (HEAD: 67f97d1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/160442 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 5, 2019

Message from Daniel Martí:

Patch Set 1: Code-Review+2

This got missed because there's a typo in the wait-release label, apologies. Will rebase and merge.


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 5, 2019

Message from Brad Fitzpatrick:

Patch Set 3: Patch Set 2 was rebased


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 5, 2019

Message from Daniel Martí:

Patch Set 2: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 5, 2019

Message from Brad Fitzpatrick:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 5, 2019

Message from Daniel Martí:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 5, 2019

Message from Leon Klingele:

Patch Set 3:

It looks like this change has been implemented in master already (although with a slightly misleading error message — it's a ReadLine error, not an error from PrintfLine):

msg, err := tc.ReadLine()
if msg == "EHLO localhost" {
tc.PrintfLine("250 mx.google.com at your service")
}
if err != nil {
errCh <- fmt.Errorf("PrintfLine: %v", err)
return
}


Please don’t reply on this GitHub thread. Visit golang.org/cl/160442.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 11, 2019
Change-Id: Ifcbd9d2961073a18a250f052180248d9bf223e97
GitHub-Last-Rev: 67f97d1
GitHub-Pull-Request: #30018
Reviewed-on: https://go-review.googlesource.com/c/go/+/160442
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.